Bug 210819

Summary: [Cocoa] Don't bother compiling UpdateInfo since it's not used
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, darin, ddkilzer, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2020-04-21 15:41:35 PDT
We don't use the UpdateInfo class in Cocoa-based builds, so let's not bother building it!
Attachments
Patch (2.89 KB, patch)
2020-04-21 15:43 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2020-04-21 15:43:28 PDT
Created attachment 397132 [details] Patch
Darin Adler
Comment 2 2020-04-21 15:46:17 PDT
Comment on attachment 397132 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397132&action=review > Source/WebKit/UIProcess/DrawingAreaProxy.h:55 > +#if USE(COORDINATED_GRAPHICS) || USE(TEXTURE_MAPPER) > +class UpdateInfo; > +#endif Seems overkill to make the forward declaration conditional. OK, but maybe not necessary to be so careful.
EWS
Comment 3 2020-04-21 16:12:33 PDT
Committed r260473: <https://trac.webkit.org/changeset/260473> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397132 [details].
Radar WebKit Bug Importer
Comment 4 2020-04-21 16:13:15 PDT
<rdar://problem/62137073>
Brent Fulgham
Comment 5 2020-04-21 16:20:12 PDT
This was actually <rdar://problem/61774766>.
Note You need to log in before you can comment on or make changes to this bug.