Bug 210819

Summary:

[Cocoa] Don't bother compiling UpdateInfo since it's not used

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit2

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cdumez, darin, ddkilzer, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Brent Fulgham 2020-04-21 15:41:35 PDT

We don't use the UpdateInfo class in Cocoa-based builds, so let's not bother building it!

Comment 1 Brent Fulgham 2020-04-21 15:43:28 PDT

Created attachment 397132 [details]
Patch

Comment 2 Darin Adler 2020-04-21 15:46:17 PDT

Comment on attachment 397132 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397132&action=review

> Source/WebKit/UIProcess/DrawingAreaProxy.h:55
> +#if USE(COORDINATED_GRAPHICS) || USE(TEXTURE_MAPPER)
> +class UpdateInfo;
> +#endif

Seems overkill to make the forward declaration conditional. OK, but maybe not necessary to be so careful.

Comment 3 EWS 2020-04-21 16:12:33 PDT

Committed r260473: <https://trac.webkit.org/changeset/260473>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397132 [details].

Comment 4 Radar WebKit Bug Importer 2020-04-21 16:13:15 PDT

<rdar://problem/62137073>

Comment 5 Brent Fulgham 2020-04-21 16:20:12 PDT

This was actually <rdar://problem/61774766>.