Bug 210817

Summary: [Web Animations] Add a supporting object for Document to manage timelines
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dino, esprehn+autocc, ews-watchlist, graouts, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dino: review+

Antoine Quint
Reported 2020-04-21 14:51:14 PDT
[Web Animations] Add a supporting object for Document to manage timelines
Attachments
Patch (19.70 KB, patch)
2020-04-21 14:54 PDT, Antoine Quint 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2020-04-21 14:54:21 PDT
Created attachment 397127 [details] Patch
Dean Jackson
Comment 2 2020-04-21 15:11:33 PDT
Comment on attachment 397127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397127&action=review > Source/WebCore/animation/DocumentTimelinesController.cpp:65 > + if (!shouldUpdateAnimations && timeline.scheduledUpdate()) Is it expensive to call scheduledUpdate()? if not, skip the !shouldUpdateAnimations > Source/WebCore/animation/DocumentTimelinesController.cpp:67 > + timelines.append(&timeline); We don't have a filter method?
Antoine Quint
Comment 3 2020-04-22 00:10:41 PDT
(In reply to Dean Jackson from comment #2) > Comment on attachment 397127 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=397127&action=review > > > Source/WebCore/animation/DocumentTimelinesController.cpp:65 > > + if (!shouldUpdateAnimations && timeline.scheduledUpdate()) > > Is it expensive to call scheduledUpdate()? if not, skip the > !shouldUpdateAnimations Sure. > > Source/WebCore/animation/DocumentTimelinesController.cpp:67 > > + timelines.append(&timeline); > > We don't have a filter method? We don't filter :)
Antoine Quint
Comment 4 2020-04-22 00:17:01 PDT
Committed r260504: <https://trac.webkit.org/changeset/260504>
Radar WebKit Bug Importer
Comment 5 2020-04-22 00:17:16 PDT
<rdar://problem/62162278>
Note You need to log in before you can comment on or make changes to this bug.