| Summary: | [Web Animations] Add a supporting object for Document to manage timelines | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
| Component: | Animations | Assignee: | Antoine Quint <graouts> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, dino, esprehn+autocc, ews-watchlist, graouts, kangil.han, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antoine Quint
2020-04-21 14:51:14 PDT
Created attachment 397127 [details]
Patch
Comment on attachment 397127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397127&action=review > Source/WebCore/animation/DocumentTimelinesController.cpp:65 > + if (!shouldUpdateAnimations && timeline.scheduledUpdate()) Is it expensive to call scheduledUpdate()? if not, skip the !shouldUpdateAnimations > Source/WebCore/animation/DocumentTimelinesController.cpp:67 > + timelines.append(&timeline); We don't have a filter method? (In reply to Dean Jackson from comment #2) > Comment on attachment 397127 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=397127&action=review > > > Source/WebCore/animation/DocumentTimelinesController.cpp:65 > > + if (!shouldUpdateAnimations && timeline.scheduledUpdate()) > > Is it expensive to call scheduledUpdate()? if not, skip the > !shouldUpdateAnimations Sure. > > Source/WebCore/animation/DocumentTimelinesController.cpp:67 > > + timelines.append(&timeline); > > We don't have a filter method? We don't filter :) Committed r260504: <https://trac.webkit.org/changeset/260504> |