Summary: | Move WebKit.WebViewCategory test to InAppBrowserPrivacy.mm | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kate Cheney <katherine_cheney> | ||||
Component: | WebKit Misc. | Assignee: | Kate Cheney <katherine_cheney> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aestes, ap, bfulgham, wilander | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Kate Cheney
2020-04-21 12:13:58 PDT
Created attachment 397104 [details]
Patch
Comment on attachment 397104 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397104&action=review rs=me > Tools/TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:-65 > - auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]); > - EXPECT_EQ([configuration _webViewCategory], _WKWebViewCategoryAppBoundDomain); Can you add an explanation to ChangeLog about why this failed? Naively, I would expect the state of an object that was just init'ed to always the the same, and not require "initializeInAppBrowserPrivacyTestSettings()". > Tools/TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:-71 > - [configuration _setWebViewCategory:_WKWebViewCategoryInAppBrowser]; > - EXPECT_EQ([configuration _webViewCategory], _WKWebViewCategoryInAppBrowser); > - > - [configuration _setWebViewCategory:_WKWebViewCategoryWebBrowser]; > - EXPECT_EQ([configuration _webViewCategory], _WKWebViewCategoryWebBrowser); Seems OK to move everything, but it may be even better to keep tests for other categories here. Committed r260451: <https://trac.webkit.org/changeset/260451> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397104 [details]. |