Bug 210809 – Fix for remoteParentObject and platformWidget not being stored properly in the AXIsolatedObject attributes variant.

• Component: New Bugs
• Status: RESOLVED FIXED

[Andres Gonzalez]

Fix for remoteParentObject and platformWidget not being stored properly in the AXIsolatedObject attributes variant.

[Andres Gonzalez]

Created attachment 397100 [details]
Patch

[chris fleizach]

Comment on attachment 397100 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397100&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:908
> +    PlatformWidget m_platformWidget;

Is PlatformWidget typedef to RetainPtr<NSView> already? can we move that out of the #if and share the same line?

[Andres Gonzalez]

(In reply to chris fleizach from comment #2)
> Comment on attachment 397100 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=397100&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:908
> > +    PlatformWidget m_platformWidget;
> 
> Is PlatformWidget typedef to RetainPtr<NSView> already? can we move that out
> of the #if and share the same line?

It is a HWND on Windows and a void* on GTK. Since this is not implemented in any other platform, I could remove the declaration from the other platforms, but thought that it might be a hint for future implementations.

[EWS]

Committed r260448: <https://trac.webkit.org/changeset/260448>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397100 [details].

[Radar WebKit Bug Importer]

<rdar://problem/62127479>