| Summary: | Fix for remoteParentObject and platformWidget not being stored properly in the AXIsolatedObject attributes variant. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||
| Component: | New Bugs | Assignee: | Andres Gonzalez <andresg_22> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Andres Gonzalez
2020-04-21 11:43:58 PDT
Created attachment 397100 [details]
Patch
Comment on attachment 397100 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397100&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:908 > + PlatformWidget m_platformWidget; Is PlatformWidget typedef to RetainPtr<NSView> already? can we move that out of the #if and share the same line? (In reply to chris fleizach from comment #2) > Comment on attachment 397100 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=397100&action=review > > > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:908 > > + PlatformWidget m_platformWidget; > > Is PlatformWidget typedef to RetainPtr<NSView> already? can we move that out > of the #if and share the same line? It is a HWND on Windows and a void* on GTK. Since this is not implemented in any other platform, I could remove the declaration from the other platforms, but thought that it might be a hint for future implementations. Committed r260448: <https://trac.webkit.org/changeset/260448> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397100 [details]. |