Bug 210808

Summary: [iOS] Provide better names for ProcessThrottler process assertions
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ggaren, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2020-04-21 11:30:32 PDT
Provide better names for ProcessThrottler process assertions, to facilitate debugging.
Attachments
Patch (12.72 KB, patch)
2020-04-21 11:31 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (12.94 KB, patch)
2020-04-21 13:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-04-21 11:31:29 PDT
Created attachment 397097 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-04-21 11:32:08 PDT
<rdar://problem/62121697>
Sam Weinig
Comment 3 2020-04-21 12:20:02 PDT
Comment on attachment 397097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397097&action=review > Source/WebKit/UIProcess/ProcessThrottler.cpp:105 > + String typeString; ASCIILiteral? > Source/WebKit/UIProcess/ProcessThrottler.cpp:115 > + case ProcessAssertionType::Foreground: > + typeString = "Foreground"; > + break; > + case ProcessAssertionType::Background: > + typeString = "Background"; > + break; > + case ProcessAssertionType::Suspended: > + typeString = "Suspended"; > + break; Why only these three?
Chris Dumez
Comment 4 2020-04-21 12:27:19 PDT
Comment on attachment 397097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397097&action=review >> Source/WebKit/UIProcess/ProcessThrottler.cpp:105 >> + String typeString; > > ASCIILiteral? Ok. >> Source/WebKit/UIProcess/ProcessThrottler.cpp:115 >> + break; > > Why only these three? Yes, we only use these 3 in the ProcessThrottler.
Chris Dumez
Comment 5 2020-04-21 12:30:09 PDT
Comment on attachment 397097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397097&action=review >>> Source/WebKit/UIProcess/ProcessThrottler.cpp:115 >>> + break; >> >> Why only these three? > > Yes, we only use these 3 in the ProcessThrottler. See ProcessThrottler::expectedAssertionType() above.
Chris Dumez
Comment 6 2020-04-21 13:38:35 PDT
Created attachment 397114 [details] Patch
Geoffrey Garen
Comment 7 2020-04-21 13:41:06 PDT
Comment on attachment 397114 [details] Patch r=me
EWS
Comment 8 2020-04-21 14:22:31 PDT
Committed r260453: <https://trac.webkit.org/changeset/260453> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397114 [details].
Sam Weinig
Comment 9 2020-04-22 18:02:22 PDT
Comment on attachment 397114 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397114&action=review > Source/WebKit/UIProcess/ProcessThrottler.cpp:115 > + case ProcessAssertionType::UnboundedNetworking: > + case ProcessAssertionType::MediaPlayback: > + case ProcessAssertionType::DependentProcessLink: Thumbs up.
Note You need to log in before you can comment on or make changes to this bug.