Bug 210803

Summary:

[ews] Display error message when submit for EWS analysis button doesn't work

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=214372

Attachments:

Description	Flags
Patch	none

Aakash Jain

Reported 2020-04-21 10:40:40 PDT

Currently the 'submit for EWS analysis' button doesn't work for security bugs which doesn't have any r? patch. However, worst part is that it silently fails, there is no error message or no clear indication that the button didn't work. Because of that users get confused (whether it is taking time, or not working, or why isn't it working, what should they do to fix it etc). EWS should display an error message when 'submit for EWS analysis' button doesn't work.

Attachments
Patch (4.84 KB, patch) 2020-04-21 10:43 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2020-04-21 10:43:05 PDT

Created attachment 397094 [details] Patch

Aakash Jain

Comment 2 2020-04-21 10:43:40 PDT

Sample runs: https://ews.webkit-uat.org/status-bubble/397091/ https://ews.webkit-uat.org/status-bubble/326588/

EWS

Comment 3 2020-04-21 11:13:40 PDT

Committed r260444: <https://trac.webkit.org/changeset/260444> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397094 [details].

Radar WebKit Bug Importer

Comment 4 2020-04-21 11:14:13 PDT

<rdar://problem/62120159>

Aakash Jain

Comment 5 2020-04-21 11:21:44 PDT

> Committed r260444: <https://trac.webkit.org/changeset/260444> Deployed on the server.

Note You need to log in before you can comment on or make changes to this bug.