Summary: | REGRESSION(r260380): [GTK] fast/mediastream/MediaStream-video-element-remove-track.html is crashing | ||
---|---|---|---|
Product: | WebKit | Reporter: | Diego Pino <dpino> |
Component: | Media | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | aboya, calvaris, lmoura |
Priority: | P2 | ||
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=191886 https://bugs.webkit.org/show_bug.cgi?id=210494 |
Description
Diego Pino
2020-04-21 08:32:14 PDT
Bisecting, I got the crashes starting right before, in r260379 (bug210494) (tracked in the same build that started crashing). As a result of fixing bug fast/mediastream/MediaStream-removeTrack-while-playing.html begins to crash in debug mode in an assertion. When a track is removed the observer is not removed and when it dies there are null objects in the observer weak hash set. Still, if you do a quick patch to remove the observer, things can still crash as track removal is racy and in release there' other crash. All this needs to be taclked as a general approach to fix track removal. This test also started to flaky timeout frequently in the release bots since r271526 (Memory pressure changes). No longer crashing. Closing and adjusting expectations. |