Bug 210792

Summary: [GTK][CMake] Make gtk-unix-print a component of FindGTK.cmake
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, cgarcia, clopez, don.olmstead, ews-watchlist, gyuyoung.kim, pnormand, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 210100    
Attachments:
Description Flags
Patch
none
Patch v2
none
Patch for landing none

Adrian Perez
Reported 2020-04-21 05:46:22 PDT
Instead of having “FindGTKUnixPrint.cmake” as a separate CMake find-module, let's make it a component of “FindGTK.cmake”. This will prevent desync between both .cmake files which can cause weirdness like e.g. configuring the build with USE_GTK4=ON and having GTK3 include paths in the build which were brought in by “FindGTKUnixPrint.cmake” which is still checking for 3.x
Attachments
Patch (6.75 KB, patch)
2020-04-21 05:49 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch v2 (9.84 KB, patch)
2020-04-21 06:00 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.90 KB, patch)
2020-04-21 08:02 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2020-04-21 05:49:07 PDT
Created attachment 397074 [details] Patch
Adrian Perez
Comment 2 2020-04-21 05:53:45 PDT
(In reply to Adrian Perez from comment #1) > Created attachment 397074 [details] > Patch This is missing the changes to use the imported target inside the following files: - Source/WebKit/PlatformGTK.cmake - Tools/TestWebKitAPI/glib/PlatformGTK.cmake I'll upload an updated patch momentarily.
Adrian Perez
Comment 3 2020-04-21 06:00:47 PDT
Created attachment 397075 [details] Patch v2
EWS
Comment 4 2020-04-21 07:24:22 PDT
/Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Adrian Perez
Comment 5 2020-04-21 08:02:09 PDT
Created attachment 397082 [details] Patch for landing
EWS
Comment 6 2020-04-21 08:26:57 PDT
Committed r260427: <https://trac.webkit.org/changeset/260427> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397082 [details].
Radar WebKit Bug Importer
Comment 7 2020-04-21 08:27:17 PDT
<rdar://problem/62109307>
Note You need to log in before you can comment on or make changes to this bug.