Bug 210792

Summary: [GTK][CMake] Make gtk-unix-print a component of FindGTK.cmake
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, cgarcia, clopez, don.olmstead, ews-watchlist, gyuyoung.kim, pnormand, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 210100    
Attachments:
Description Flags
Patch
none
Patch v2
none
Patch for landing none

Description Adrian Perez 2020-04-21 05:46:22 PDT 
Instead of having “FindGTKUnixPrint.cmake” as a separate CMake
find-module, let's make it a component of “FindGTK.cmake”. This
will prevent desync between both .cmake files which can cause
weirdness like e.g. configuring the build with USE_GTK4=ON and
having GTK3 include paths in the build which were brought in
by “FindGTKUnixPrint.cmake” which is still checking for 3.x
Comment 1 Adrian Perez 2020-04-21 05:49:07 PDT 
Created attachment 397074 [details]
Patch
Comment 2 Adrian Perez 2020-04-21 05:53:45 PDT 
(In reply to Adrian Perez from comment #1)
> Created attachment 397074 [details]
> Patch

This is missing the changes to use the imported target inside the
following files:

 - Source/WebKit/PlatformGTK.cmake
 - Tools/TestWebKitAPI/glib/PlatformGTK.cmake

I'll upload an updated patch momentarily.
Comment 3 Adrian Perez 2020-04-21 06:00:47 PDT 
Created attachment 397075 [details]
Patch v2
Comment 4 EWS 2020-04-21 07:24:22 PDT 
/Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 5 Adrian Perez 2020-04-21 08:02:09 PDT 
Created attachment 397082 [details]
Patch for landing
Comment 6 EWS 2020-04-21 08:26:57 PDT 
Committed r260427: <https://trac.webkit.org/changeset/260427>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397082 [details].
Comment 7 Radar WebKit Bug Importer 2020-04-21 08:27:17 PDT 
<rdar://problem/62109307>