Bug 210785

Summary: [Win] Use generic WorkQueue instead of WorkQueueWin.cpp
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Web Template FrameworkAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, cdumez, cmarcelo, darin, don.olmstead, ews-watchlist, gyuyoung.kim, ross.kirsling, ryuan.choi, sergio, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=186455
Attachments:
Description Flags
WIP patch
none
Patch
none
Patch for landing none

Fujii Hironori
Reported 2020-04-20 23:20:26 PDT
[Win] Use generic WorkQueue instead of WorkQueueWin.cpp
Attachments
WIP patch (11.57 KB, patch)
2020-04-20 23:20 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (13.24 KB, patch)
2020-04-21 14:26 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.02 KB, patch)
2020-04-21 16:46 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2020-04-20 23:20:43 PDT
Created attachment 397056 [details] WIP patch
Fujii Hironori
Comment 2 2020-04-21 14:22:06 PDT
WorkQueueWin is using random threads to executing dispatched functions. This is not desired for IPC::Connection because it need to call CancelIo API in the thread started aync ReadFile operations. (Bug 209847 Comment 25)
Fujii Hironori
Comment 3 2020-04-21 14:26:38 PDT
Created attachment 397120 [details] Patch
Darin Adler
Comment 4 2020-04-21 14:38:01 PDT
Comment on attachment 397120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397120&action=review > Source/WTF/wtf/WorkQueue.h:35 > -#if USE(COCOA_EVENT_LOOP) > +#if PLATFORM(COCOA) Why is this a good change? Our overall plan is to eventually cut PLATFORM(XXX) down to an absolute minimum. Seems sad to move in the other direction.
Fujii Hironori
Comment 5 2020-04-21 15:03:48 PDT
Comment on attachment 397120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397120&action=review Thank you for the review. >> Source/WTF/wtf/WorkQueue.h:35 >> +#if PLATFORM(COCOA) > > Why is this a good change? Our overall plan is to eventually cut PLATFORM(XXX) down to an absolute minimum. Seems sad to move in the other direction. Agreed. Will fix. I think USE_*_EVENT_LOOP macros should be refined. But it is another topic.
Fujii Hironori
Comment 6 2020-04-21 16:46:25 PDT
Created attachment 397139 [details] Patch for landing
Fujii Hironori
Comment 7 2020-04-21 17:30:00 PDT
Comment on attachment 397139 [details] Patch for landing Clearing flags on attachment: 397139 Committed r260477: <https://trac.webkit.org/changeset/260477>
Fujii Hironori
Comment 8 2020-04-21 17:30:03 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2020-04-21 17:31:14 PDT
<rdar://problem/62140869>
Note You need to log in before you can comment on or make changes to this bug.