Summary: | Support toggling debug overlay for touch action region and editable element region independent from non-fast scrollable region | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||
Component: | WebKit Misc. | Assignee: | Daniel Bates <dbates> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dino, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Local Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Daniel Bates
2020-04-20 16:44:57 PDT
Created attachment 397038 [details]
Patch
Comment on attachment 397038 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397038&action=review > Source/WebCore/rendering/RenderLayer.cpp:7055 > + if (renderer().settings().visibleDebugOverlayRegions() & (TouchActionRegion | EditableElementRegion)) I wanted to make this setting return an OptionSet<>, but that involves some work due to how settings are generated. For now, I deferred this. Comment on attachment 397038 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397038&action=review > Source/WebCore/ChangeLog:8 > + Break out the touch action region and editable element region debug overlays into there own their > Source/WebCore/ChangeLog:19 > + (WebCore::RenderLayerBacking::paintDebugOverlays): Condition the paintinf of touch action region painting >> Source/WebCore/rendering/RenderLayer.cpp:7055 >> + if (renderer().settings().visibleDebugOverlayRegions() & (TouchActionRegion | EditableElementRegion)) > > I wanted to make this setting return an OptionSet<>, but that involves some work due to how settings are generated. For now, I deferred this. Yeah, that's a shame. It's ok as a mask though. > Source/WebCore/rendering/RenderLayerBacking.cpp:3088 > + Color regionColor(0, 0, 255, 50); At some point in the future we should collect all our colors into a single place so we can document them easily. Created attachment 397296 [details]
To Land
Committed r260547: <https://trac.webkit.org/changeset/260547> |