Bug 210765

Summary: Add more structure-cloning tests for BigInt
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, ews-watchlist, jsbell, mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Patch
none
Patch mark.lam: review+

Yusuke Suzuki
Reported 2020-04-20 13:40:09 PDT
We should have tests outside of WPT too.
Attachments
WIP (5.96 KB, patch)
2020-04-20 14:00 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (9.15 KB, patch)
2020-04-20 14:28 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (12.40 KB, patch)
2020-04-20 14:34 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-04-20 14:00:06 PDT
Created attachment 397011 [details] WIP Patch for collecting expect files from GTK etc.
Yusuke Suzuki
Comment 2 2020-04-20 14:15:03 PDT
(In reply to Yusuke Suzuki from comment #1) > Created attachment 397011 [details] > WIP > > Patch for collecting expect files from GTK etc. Ugh, GTK is not running tests in EWS.
Yusuke Suzuki
Comment 3 2020-04-20 14:28:42 PDT
Created attachment 397017 [details] Patch
Yusuke Suzuki
Comment 4 2020-04-20 14:34:27 PDT
Created attachment 397018 [details] Patch
Mark Lam
Comment 5 2020-04-20 14:40:08 PDT
Comment on attachment 397018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397018&action=review r=me > LayoutTests/fast/dom/Window/window-postmessage-clone.html:327 > + 'var i = Object(100000000000000000000n); ' + There’s a comment above this that should be updated to include BigInt too.
Yusuke Suzuki
Comment 6 2020-04-20 14:40:30 PDT
Comment on attachment 397018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397018&action=review Thanks! >> LayoutTests/fast/dom/Window/window-postmessage-clone.html:327 >> + 'var i = Object(100000000000000000000n); ' + > > There’s a comment above this that should be updated to include BigInt too. Fixed.
Yusuke Suzuki
Comment 7 2020-04-20 15:26:29 PDT
WK1 EWS is green and seems that this test is skipped in wk2. Landing.
Yusuke Suzuki
Comment 8 2020-04-20 15:33:06 PDT
Committed r260404: <https://trac.webkit.org/changeset/260404>
Radar WebKit Bug Importer
Comment 9 2020-04-20 15:34:14 PDT
<rdar://problem/62079013>
Note You need to log in before you can comment on or make changes to this bug.