| Summary: | [JSC] Skip test262 for non-safe-integer range BigIntConstructor | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||
| Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Yusuke Suzuki
2020-04-20 09:21:02 PDT
Created attachment 396993 [details]
Patch
Comment on attachment 396993 [details]
Patch
This fixes trivial test262 failure.
Comment on attachment 396993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396993&action=review r=me with nit. > Source/JavaScriptCore/ChangeLog:8 > + Maybe, the spec is changed at some point, and now BigInt constructor accepts non-safe-integers. Nit, I would phrase this as: Maybe the spec changed at some point but BigInt constructor accepts non-safe-integers. Created attachment 396994 [details]
Patch
Comment on attachment 396994 [details]
Patch
Can we file a bug and put a FIXME in our BigInt constructor?
(In reply to Keith Miller from comment #5) > Comment on attachment 396994 [details] > Patch > > Can we file a bug and put a FIXME in our BigInt constructor? https://bugs.webkit.org/show_bug.cgi?id=210755 Filed. And added FIXME. Tested test262 locally since it is not included in EWS. Created attachment 396998 [details]
Patch for landing
Patch for landing
Committed r260384: <https://trac.webkit.org/changeset/260384> |