Summary: | Fix CLoop build for iterator opcodes | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||||
Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ews-watchlist, mark.lam, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Keith Miller
2020-04-18 19:05:37 PDT
Created attachment 396884 [details]
Patch
Comment on attachment 396884 [details]
Patch
r=me
Comment on attachment 396884 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396884&action=review > Source/JavaScriptCore/bytecode/BytecodeList.rb:1326 > +op :llint_cloop_did_return_from_js_46 I was too fast in r+-ing this patch, I think it is missing matching code in Bytecodes.h. Look for macro(llint_cloop_did_return_from_js_1, 1), and add similar ones for the new ops you are adding. (In reply to Robin Morisset from comment #3) > Comment on attachment 396884 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=396884&action=review > > > Source/JavaScriptCore/bytecode/BytecodeList.rb:1326 > > +op :llint_cloop_did_return_from_js_46 > > I was too fast in r+-ing this patch, I think it is missing matching code in > Bytecodes.h. Look for macro(llint_cloop_did_return_from_js_1, 1), and add > similar ones for the new ops you are adding. Isn't Bytecodes.h auto generated? Looks like I need to generate superfluous labels for 32-bit... Created attachment 396885 [details]
Patch for landing
Created attachment 396888 [details]
Patch for landing
Committed r260333: <https://trac.webkit.org/changeset/260333> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396888 [details]. |