Bug 210707

Summary: CSS env variables are exposed in getComputedStyle enumeration.
Product: WebKit Reporter: Emilio Cobos Álvarez (:emilio) <emilio>
Component: CSSAssignee: Emilio Cobos Álvarez (:emilio) <emilio>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, macpherson, menard, mjs, obrufau, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 210695    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Emilio Cobos Álvarez (:emilio)
Reported 2020-04-18 17:27:30 PDT
Similar to to bug 210695. WebKit stores the env variable values in the inherited properties.
Attachments
Patch (7.53 KB, patch)
2020-04-18 17:50 PDT, Emilio Cobos Álvarez (:emilio) 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.59 KB, patch)
2020-04-19 07:21 PDT, Emilio Cobos Álvarez (:emilio) 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.59 KB, patch)
2020-04-19 07:23 PDT, Emilio Cobos Álvarez (:emilio) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Emilio Cobos Álvarez (:emilio)
Comment 1 2020-04-18 17:50:17 PDT
Created attachment 396880 [details] Patch
Emilio Cobos Álvarez (:emilio)
Comment 2 2020-04-19 07:21:01 PDT
Created attachment 396906 [details] Patch for landing
EWS
Comment 3 2020-04-19 07:21:45 PDT
Annti Koivisto found in /Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Emilio Cobos Álvarez (:emilio)
Comment 4 2020-04-19 07:22:55 PDT
Whoops, that happens for filing the changelog manually :)
Emilio Cobos Álvarez (:emilio)
Comment 5 2020-04-19 07:23:16 PDT
Created attachment 396907 [details] Patch for landing
EWS
Comment 6 2020-04-19 08:55:04 PDT
Found 1 new test failure: fast/layoutformattingcontext/simple-absolute-positioned-replaced-inline-element-with-percentage-height.html
Emilio Cobos Álvarez (:emilio)
Comment 7 2020-04-19 10:59:31 PDT
Comment on attachment 396907 [details] Patch for landing Doesn't look related.
EWS
Comment 8 2020-04-19 11:01:22 PDT
Committed r260340: <https://trac.webkit.org/changeset/260340> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396907 [details].
Note You need to log in before you can comment on or make changes to this bug.