Bug 210691

Summary:

[CMake] Consolidate TestNetscapePlugin build

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

CMake

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, aperez, cgarcia, ews-watchlist, fujii.hironori, gyuyoung.kim, mcatanzaro, ryuan.choi, sergio

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP Patch	none
WIP Patch	none
Patch	none
Patch	none
Patch	fujii.hironori: review+
Patch	don.olmstead: commit-queue-
Patch	none

Don Olmstead

Reported 2020-04-18 10:57:35 PDT

Currently in DumpRenderTree the CMakeLists.txt has definitions for TestNetscapePlugin but also there's a root CMakeLists.txt in that directory.

Attachments
WIP Patch (12.14 KB, patch) 2020-04-18 11:46 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (12.15 KB, patch) 2020-04-18 12:00 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (13.66 KB, patch) 2020-04-18 12:12 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (13.66 KB, patch) 2020-04-18 12:35 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (13.66 KB, patch) 2020-04-18 14:23 PDT, Don Olmstead	fujii.hironori: review+	Details Formatted Diff Diff
Patch (13.79 KB, patch) 2020-04-19 08:48 PDT, Don Olmstead	don.olmstead: commit-queue-	Details Formatted Diff Diff
Patch (13.70 KB, patch) 2020-04-19 09:08 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Don Olmstead

Comment 1 2020-04-18 11:46:04 PDT Comment hidden (obsolete)

Created attachment 396857 [details] WIP Patch

Don Olmstead

Comment 2 2020-04-18 12:00:17 PDT Comment hidden (obsolete)

Created attachment 396858 [details] WIP Patch

Don Olmstead

Comment 3 2020-04-18 12:12:26 PDT Comment hidden (obsolete)

Created attachment 396859 [details] Patch

Don Olmstead

Comment 4 2020-04-18 12:35:40 PDT Comment hidden (obsolete)

Created attachment 396860 [details] Patch

Don Olmstead

Comment 5 2020-04-18 14:23:36 PDT Comment hidden (obsolete)

Created attachment 396862 [details] Patch

Don Olmstead

Comment 6 2020-04-18 19:50:31 PDT

Comment on attachment 396862 [details] Patch The AppleWin build is failing but I think it just needs a clean build.

Fujii Hironori

Comment 7 2020-04-19 00:18:05 PDT

Comment on attachment 396862 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396862&action=review > Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:49 > +WEBKIT_FRAMEWORK(TestNetscapePlugIn) You use WEBKIT_FRAMEWORK, but you don't set TestNetscapePlugIn_LIBRARY_TYPE to SHARED. Do you specify it anywhere?

Don Olmstead

Comment 8 2020-04-19 08:48:14 PDT Comment hidden (obsolete)

Created attachment 396911 [details] Patch

Don Olmstead

Comment 9 2020-04-19 09:08:44 PDT

Created attachment 396913 [details] Patch

EWS

Comment 10 2020-04-19 11:12:44 PDT

Committed r260341: <https://trac.webkit.org/changeset/260341> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396913 [details].

Note You need to log in before you can comment on or make changes to this bug.