Summary: | [CMake] Consolidate TestNetscapePlugin build | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||||||||||||
Component: | CMake | Assignee: | Don Olmstead <don.olmstead> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | annulen, aperez, cgarcia, ews-watchlist, gyuyoung.kim, Hironori.Fujii, mcatanzaro, ryuan.choi, sergio | ||||||||||||||||
Priority: | P2 | ||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Attachments: |
|
Description
Don Olmstead
2020-04-18 10:57:35 PDT
Created attachment 396857 [details]
WIP Patch
Created attachment 396858 [details]
WIP Patch
Created attachment 396859 [details]
Patch
Created attachment 396860 [details]
Patch
Created attachment 396862 [details]
Patch
Comment on attachment 396862 [details]
Patch
The AppleWin build is failing but I think it just needs a clean build.
Comment on attachment 396862 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396862&action=review > Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:49 > +WEBKIT_FRAMEWORK(TestNetscapePlugIn) You use WEBKIT_FRAMEWORK, but you don't set TestNetscapePlugIn_LIBRARY_TYPE to SHARED. Do you specify it anywhere? Created attachment 396911 [details]
Patch
Created attachment 396913 [details]
Patch
Committed r260341: <https://trac.webkit.org/changeset/260341> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396913 [details]. |