Bug 210691

Summary: [CMake] Consolidate TestNetscapePlugin build
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, cgarcia, ews-watchlist, gyuyoung.kim, Hironori.Fujii, mcatanzaro, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
none
WIP Patch
none
Patch
none
Patch
none
Patch
Hironori.Fujii: review+
Patch
don.olmstead: commit-queue-
Patch none

Description Don Olmstead 2020-04-18 10:57:35 PDT
Currently in DumpRenderTree the CMakeLists.txt has definitions for TestNetscapePlugin but also there's a root CMakeLists.txt in that directory.
Comment 1 Don Olmstead 2020-04-18 11:46:04 PDT Comment hidden (obsolete)
Comment 2 Don Olmstead 2020-04-18 12:00:17 PDT Comment hidden (obsolete)
Comment 3 Don Olmstead 2020-04-18 12:12:26 PDT Comment hidden (obsolete)
Comment 4 Don Olmstead 2020-04-18 12:35:40 PDT Comment hidden (obsolete)
Comment 5 Don Olmstead 2020-04-18 14:23:36 PDT Comment hidden (obsolete)
Comment 6 Don Olmstead 2020-04-18 19:50:31 PDT
Comment on attachment 396862 [details]
Patch

The AppleWin build is failing but I think it just needs a clean build.
Comment 7 Fujii Hironori 2020-04-19 00:18:05 PDT
Comment on attachment 396862 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396862&action=review

> Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:49
> +WEBKIT_FRAMEWORK(TestNetscapePlugIn)

You use WEBKIT_FRAMEWORK, but you don't set TestNetscapePlugIn_LIBRARY_TYPE to SHARED. Do you specify it anywhere?
Comment 8 Don Olmstead 2020-04-19 08:48:14 PDT Comment hidden (obsolete)
Comment 9 Don Olmstead 2020-04-19 09:08:44 PDT
Created attachment 396913 [details]
Patch
Comment 10 EWS 2020-04-19 11:12:44 PDT
Committed r260341: <https://trac.webkit.org/changeset/260341>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396913 [details].