Bug 210676 – REGRESSION (r260278): TestWebKitAPI.Fullscreen.Delegate is timing out on macOS bots

• Component: New Bugs
• Status: REOPENED

[Ryan Haddad]

TestWebKitAPI.Fullscreen.Delegate is consistently timing out on macOS Debug bots, and appears to be flaky on macOS release bots.

Timeout

    TestWebKitAPI.Fullscreen.Delegate
        _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.

https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.Fullscreen.Delegate

[Radar WebKit Bug Importer]

<rdar://problem/61953702>

[Jer Noble]

Created attachment 397281 [details]
Patch

[Jer Noble]

Created attachment 397288 [details]
Patch

[Daniel Bates]

Comment on attachment 397288 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397288&action=review

Patch looks good. A better patch would audit all of the unit tests and fix this up. For future thought, design to prevent this kind of mistake or detect it.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:89
> +    RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 100, 100) configuration:configuration.get()]);

This ok as-is. No change needed. Optimal solution would use auto.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenLayoutConstraints.mm:59
> +    RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 100, 100) configuration:configuration.get()]);

Ditto.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:119
> +    RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 640, 480) configuration:configuration.get()]);

Ditto.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm:62
> +    RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 100, 100) configuration:configuration.get()]);

Ditto.

[Jer Noble]

(In reply to Daniel Bates from comment #4)
> Comment on attachment 397288 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=397288&action=review
> 
> Patch looks good. A better patch would audit all of the unit tests and fix
> this up. For future thought, design to prevent this kind of mistake or
> detect it.

Indeed. This was the result of a minor audit itself.

> > Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:89
> > +    RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 100, 100) configuration:configuration.get()]);
> 
> This ok as-is. No change needed. Optimal solution would use auto.


Okay, for the sake of expediency, I'm not going to update these all to use auto at this time. 

Thanks!

[EWS]

Committed r260606: <https://trac.webkit.org/changeset/260606>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397288 [details].

[Ryan Haddad]

(In reply to EWS from comment #6)
> Committed r260606: <https://trac.webkit.org/changeset/260606>
Sadly, this has not resolved the timeouts on the bots.

[Jer Noble]

*** Bug 211237 has been marked as a duplicate of this bug. ***

[Ryan Haddad]

Reopening since it isn't fixed.

[Ryan Haddad]

Disabled the test in https://trac.webkit.org/changeset/261243/webkit to get the bots to green.

[Ryan Haddad]

(In reply to Ryan Haddad from comment #10)
> Disabled the test in https://trac.webkit.org/changeset/261243/webkit to get
> the bots to green.
Specifically, I disabled the Fullscreen.Alert test since it was causing the subsequent test to fail.