Summary: | REGRESSION (r260278): TestWebKitAPI.Fullscreen.Delegate is timing out on macOS bots | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||||
Component: | New Bugs | Assignee: | Peng Liu <peng.liu6> | ||||||
Status: | REOPENED --- | ||||||||
Severity: | Normal | CC: | jer.noble, peng.liu6, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=210662 | ||||||||
Attachments: |
|
Description
Ryan Haddad
2020-04-17 15:43:40 PDT
Created attachment 397281 [details]
Patch
Created attachment 397288 [details]
Patch
Comment on attachment 397288 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397288&action=review Patch looks good. A better patch would audit all of the unit tests and fix this up. For future thought, design to prevent this kind of mistake or detect it. > Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:89 > + RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 100, 100) configuration:configuration.get()]); This ok as-is. No change needed. Optimal solution would use auto. > Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenLayoutConstraints.mm:59 > + RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 100, 100) configuration:configuration.get()]); Ditto. > Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:119 > + RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 640, 480) configuration:configuration.get()]); Ditto. > Tools/TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm:62 > + RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 100, 100) configuration:configuration.get()]); Ditto. (In reply to Daniel Bates from comment #4) > Comment on attachment 397288 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=397288&action=review > > Patch looks good. A better patch would audit all of the unit tests and fix > this up. For future thought, design to prevent this kind of mistake or > detect it. Indeed. This was the result of a minor audit itself. > > Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:89 > > + RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 100, 100) configuration:configuration.get()]); > > This ok as-is. No change needed. Optimal solution would use auto. Okay, for the sake of expediency, I'm not going to update these all to use auto at this time. Thanks! Committed r260606: <https://trac.webkit.org/changeset/260606> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397288 [details]. (In reply to EWS from comment #6) > Committed r260606: <https://trac.webkit.org/changeset/260606> Sadly, this has not resolved the timeouts on the bots. *** Bug 211237 has been marked as a duplicate of this bug. *** Reopening since it isn't fixed. Disabled the test in https://trac.webkit.org/changeset/261243/webkit to get the bots to green. (In reply to Ryan Haddad from comment #10) > Disabled the test in https://trac.webkit.org/changeset/261243/webkit to get > the bots to green. Specifically, I disabled the Fullscreen.Alert test since it was causing the subsequent test to fail. |