Bug 210668

Summary: Reduce parameter list of the FrameLoadRequest constructor
Product: WebKit Reporter: Rob Buis <rbuis>
Component: New BugsAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, ews-watchlist, hi, japhet, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Rob Buis
Reported 2020-04-17 13:41:35 PDT
Reduce parameter list of the FrameLoadRequest constructor.
Attachments
Patch (50.65 KB, patch)
2020-04-17 13:51 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-04-17 13:51:25 PDT
Created attachment 396792 [details] Patch
Rob Buis
Comment 2 2020-04-17 14:32:16 PDT
Comment on attachment 396792 [details] Patch Note that the parameter list can be reduced more or less, this is a somewhat arbitrary length. It is also possible that some of the remaining parameters are better candidates for setters.
EWS
Comment 3 2020-04-18 10:04:11 PDT
Committed r260317: <https://trac.webkit.org/changeset/260317> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396792 [details].
Radar WebKit Bug Importer
Comment 4 2020-04-18 10:05:23 PDT
<rdar://problem/61975226>
Note You need to log in before you can comment on or make changes to this bug.