Bug 210667

Summary: [JSC] We do not need to have exit-check for Map/Set iterator functions
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED INVALID    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 210678    
Bug Blocks:    
Attachments:
Description Flags
Patch msaboff: review+

Yusuke Suzuki
Reported 2020-04-17 13:13:56 PDT
[JSC] We do not need to have exit-check for Map/Set iterator functions
Attachments
Patch (2.13 KB, patch)
2020-04-17 13:16 PDT, Yusuke Suzuki 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-04-17 13:16:21 PDT
Created attachment 396788 [details] Patch
Michael Saboff
Comment 2 2020-04-17 13:52:18 PDT
Comment on attachment 396788 [details] Patch r=me
Yusuke Suzuki
Comment 3 2020-04-17 14:03:13 PDT
Committed r260279: <https://trac.webkit.org/changeset/260279>
Radar WebKit Bug Importer
Comment 4 2020-04-17 14:04:14 PDT
<rdar://problem/61949524>
Saam Barati
Comment 5 2020-04-17 15:53:38 PDT
Comment on attachment 396788 [details] Patch But throwing an exception is something the compiler can handle. Exitting always will pessimize the code to a lower tier
Yusuke Suzuki
Comment 6 2020-04-17 15:59:22 PDT
(In reply to Saam Barati from comment #5) > Comment on attachment 396788 [details] > Patch > > But throwing an exception is something the compiler can handle. Exitting > always will pessimize the code to a lower tier Oh, interesting. So maybe we should keep this thing.
WebKit Commit Bot
Comment 7 2020-04-17 16:00:28 PDT
Re-opened since this is blocked by bug 210678
Note You need to log in before you can comment on or make changes to this bug.