Summary: | Bring Fullscreen API + alert() behavior from iOS to macOS | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, eric.carlson, jberlin, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=210676 | ||||||||
Attachments: |
|
Description
Jer Noble
2020-04-17 11:20:12 PDT
Created attachment 396777 [details]
Patch
Comment on attachment 396777 [details]
Patch
Regression test?
We should be able to write an API test for both macOS and iOS verifying that we exit fullscreen mode when the page fires an alert(). Will add before landing. Created attachment 396779 [details]
Patch for landing
Committed r260278: <https://trac.webkit.org/changeset/260278> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396779 [details]. |