Bug 210662

Summary: Bring Fullscreen API + alert() behavior from iOS to macOS
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, jberlin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210676
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing none

Description Jer Noble 2020-04-17 11:20:12 PDT
Bring Fullscreen API + alert() behavior from iOS to macOS
Comment 1 Jer Noble 2020-04-17 11:23:44 PDT
Created attachment 396777 [details]
Patch
Comment 2 Darin Adler 2020-04-17 11:24:58 PDT
Comment on attachment 396777 [details]
Patch

Regression test?
Comment 3 Jer Noble 2020-04-17 11:35:43 PDT
We should be able to write an API test for both macOS and iOS verifying that we exit fullscreen mode when the page fires an alert(). Will add before landing.
Comment 4 Jer Noble 2020-04-17 12:07:53 PDT
Created attachment 396779 [details]
Patch for landing
Comment 5 Jer Noble 2020-04-17 12:44:20 PDT
<rdar://problem/60684195>
Comment 6 EWS 2020-04-17 13:41:15 PDT
Committed r260278: <https://trac.webkit.org/changeset/260278>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396779 [details].