| Summary: | Reduce test iterations for stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js on mips | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Paulo Matos <pmatos> | ||||||
| Component: | New Bugs | Assignee: | Paulo Matos <pmatos> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ticaiolima, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Paulo Matos
2020-04-17 00:54:41 PDT
Created attachment 396745 [details]
Patch
Created attachment 396746 [details]
Patch
Comment on attachment 396746 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396746&action=review > JSTests/stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js:4 > +iterations = typeof(iterations) === 'undefined' ? 10000000 : iterations; It is possible to use `iterations = iterations === undefined ? 10000000 : iterations;` (In reply to Caio Lima from comment #3) > Comment on attachment 396746 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=396746&action=review > > > JSTests/stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js:4 > > +iterations = typeof(iterations) === 'undefined' ? 10000000 : iterations; > > It is possible to use `iterations = iterations === undefined ? 10000000 : > iterations;` After discussing elsewhere with Caio on this, we decided to keep as is since other parts of the codebase use the `typeof(X) === 'undefined'` style. Comment on attachment 396746 [details]
Patch
r=me
Committed r260253: <https://trac.webkit.org/changeset/260253> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396746 [details]. |