Bug 210641

Summary: Reduce test iterations for stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js on mips
Product: WebKit Reporter: Paulo Matos <pmatos>
Component: New BugsAssignee: Paulo Matos <pmatos>
Status: RESOLVED FIXED    
Severity: Normal CC: ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Paulo Matos
Reported 2020-04-17 00:54:41 PDT
Reduce test iterations for mips
Attachments
Patch (1.61 KB, patch)
2020-04-17 00:57 PDT, Paulo Matos 		no flags
DetailsFormatted DiffDiff
Patch (1.69 KB, patch)
2020-04-17 02:00 PDT, Paulo Matos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Paulo Matos
Comment 1 2020-04-17 00:57:49 PDT
Created attachment 396745 [details] Patch
Paulo Matos
Comment 2 2020-04-17 02:00:12 PDT
Created attachment 396746 [details] Patch
Caio Lima
Comment 3 2020-04-17 04:03:26 PDT
Comment on attachment 396746 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396746&action=review > JSTests/stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js:4 > +iterations = typeof(iterations) === 'undefined' ? 10000000 : iterations; It is possible to use `iterations = iterations === undefined ? 10000000 : iterations;`
Paulo Matos
Comment 4 2020-04-17 06:03:02 PDT
(In reply to Caio Lima from comment #3) > Comment on attachment 396746 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=396746&action=review > > > JSTests/stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js:4 > > +iterations = typeof(iterations) === 'undefined' ? 10000000 : iterations; > > It is possible to use `iterations = iterations === undefined ? 10000000 : > iterations;` After discussing elsewhere with Caio on this, we decided to keep as is since other parts of the codebase use the `typeof(X) === 'undefined'` style.
Yusuke Suzuki
Comment 5 2020-04-17 08:40:12 PDT
Comment on attachment 396746 [details] Patch r=me
EWS
Comment 6 2020-04-17 08:42:01 PDT
Committed r260253: <https://trac.webkit.org/changeset/260253> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396746 [details].
Radar WebKit Bug Importer
Comment 7 2020-04-17 08:42:12 PDT
<rdar://problem/61936417>
Note You need to log in before you can comment on or make changes to this bug.