Bug 210631

Summary: GetTypedArrayByteOffset is broken on arm64e
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
mark.lam: review+
patch for landing
none
patch for landing none

Description Saam Barati 2020-04-16 19:11:32 PDT 
- We compare against 0 instead of the "null" signed vector
Comment 1 Saam Barati 2020-04-16 19:26:30 PDT 
Created attachment 396733 [details]
patch
Comment 2 Mark Lam 2020-04-16 19:43:53 PDT 
Comment on attachment 396733 [details]
patch

r=me
Comment 3 Saam Barati 2020-04-17 08:58:43 PDT 
Seems like my change breaks byteOffset in C++. Question is: is that same branch also broken in JITCode or is DataView unreachable?
Comment 4 Saam Barati 2020-04-17 10:57:14 PDT 
(In reply to Saam Barati from comment #3)
> Seems like my change breaks byteOffset in C++. Question is: is that same
> branch also broken in JITCode or is DataView unreachable?

Yeah, not reachable.
Comment 5 Saam Barati 2020-04-17 11:00:04 PDT 
Created attachment 396774 [details]
patch for landing
Comment 6 Saam Barati 2020-04-17 11:00:58 PDT 
Created attachment 396775 [details]
patch for landing
Comment 7 EWS 2020-04-17 14:48:26 PDT 
Committed r260289: <https://trac.webkit.org/changeset/260289>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396775 [details].
Comment 8 Radar WebKit Bug Importer 2020-04-17 14:49:16 PDT 
<rdar://problem/61951457>