Bug 210631

Summary: GetTypedArrayByteOffset is broken on arm64e
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
mark.lam: review+
patch for landing
none
patch for landing none

Saam Barati
Reported 2020-04-16 19:11:32 PDT
- We compare against 0 instead of the "null" signed vector
Attachments
patch (8.75 KB, patch)
2020-04-16 19:26 PDT, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
patch for landing (7.99 KB, patch)
2020-04-17 11:00 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch for landing (7.99 KB, patch)
2020-04-17 11:00 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2020-04-16 19:26:30 PDT
Created attachment 396733 [details] patch
Mark Lam
Comment 2 2020-04-16 19:43:53 PDT
Comment on attachment 396733 [details] patch r=me
Saam Barati
Comment 3 2020-04-17 08:58:43 PDT
Seems like my change breaks byteOffset in C++. Question is: is that same branch also broken in JITCode or is DataView unreachable?
Saam Barati
Comment 4 2020-04-17 10:57:14 PDT
(In reply to Saam Barati from comment #3) > Seems like my change breaks byteOffset in C++. Question is: is that same > branch also broken in JITCode or is DataView unreachable? Yeah, not reachable.
Saam Barati
Comment 5 2020-04-17 11:00:04 PDT
Created attachment 396774 [details] patch for landing
Saam Barati
Comment 6 2020-04-17 11:00:58 PDT
Created attachment 396775 [details] patch for landing
EWS
Comment 7 2020-04-17 14:48:26 PDT
Committed r260289: <https://trac.webkit.org/changeset/260289> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396775 [details].
Radar WebKit Bug Importer
Comment 8 2020-04-17 14:49:16 PDT
<rdar://problem/61951457>
Note You need to log in before you can comment on or make changes to this bug.