Bug 210624

Summary: Add some more tests for -focusTextInputContext:placeCaretAt:completionHandler:
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
More tests
none
More tests
none
To Land none

Daniel Bates
Reported 2020-04-16 15:54:54 PDT
Add some more tests for -focusTextInputContext:placeCaretAt:completionHandler:.
Attachments
More tests (10.59 KB, patch)
2020-04-16 16:14 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
More tests (10.67 KB, patch)
2020-04-16 16:21 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
To Land (10.72 KB, patch)
2020-04-18 16:20 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2020-04-16 16:14:47 PDT
Created attachment 396715 [details] More tests
Daniel Bates
Comment 2 2020-04-16 16:20:54 PDT
Comment on attachment 396715 [details] More tests View in context: https://bugs.webkit.org/attachment.cgi?id=396715&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:322 > + EXPECT_EQ(1, [[webView objectByEvaluatingJavaScript:@"document.activeElement.selectionStart"] intValue]); This is wrong. It doesn't set the selection. I lost my change!
Daniel Bates
Comment 3 2020-04-16 16:21:13 PDT
Created attachment 396716 [details] More tests
Daniel Bates
Comment 4 2020-04-16 16:26:58 PDT
Comment on attachment 396716 [details] More tests View in context: https://bugs.webkit.org/attachment.cgi?id=396716&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:326 > + // Use -focusTextInputContext: to place the caret the beginning of the field; no change because the field is already focused. "caret the" => caret at the
Daniel Bates
Comment 5 2020-04-18 16:20:07 PDT
Created attachment 396871 [details] To Land
Daniel Bates
Comment 6 2020-04-18 16:20:28 PDT
Committed r260327: <https://trac.webkit.org/changeset/260327>
Radar WebKit Bug Importer
Comment 7 2020-04-18 16:21:13 PDT
<rdar://problem/61987114>
Note You need to log in before you can comment on or make changes to this bug.