Summary: | Add some more tests for -focusTextInputContext:placeCaretAt:completionHandler: | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||
Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | simon.fraser, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Local Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Daniel Bates
2020-04-16 15:54:54 PDT
Created attachment 396715 [details]
More tests
Comment on attachment 396715 [details] More tests View in context: https://bugs.webkit.org/attachment.cgi?id=396715&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:322 > + EXPECT_EQ(1, [[webView objectByEvaluatingJavaScript:@"document.activeElement.selectionStart"] intValue]); This is wrong. It doesn't set the selection. I lost my change! Created attachment 396716 [details]
More tests
Comment on attachment 396716 [details] More tests View in context: https://bugs.webkit.org/attachment.cgi?id=396716&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:326 > + // Use -focusTextInputContext: to place the caret the beginning of the field; no change because the field is already focused. "caret the" => caret at the Created attachment 396871 [details]
To Land
Committed r260327: <https://trac.webkit.org/changeset/260327> |