Bug 210606

Summary: Stop including style rules related to media controls in the UA style sheet when Modern Media Controls are enabled
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, eric.carlson, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, jer.noble, koivisto, macpherson, menard, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch dbates: review+

Antoine Quint
Reported 2020-04-16 09:23:05 PDT
Stop including style rules related to media controls in the UA style sheet when Modern Media Controls are enabled
Attachments
Patch (2.87 KB, patch)
2020-04-16 09:25 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (4.05 KB, patch)
2020-04-17 08:04 PDT, Antoine Quint 		dbates: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2020-04-16 09:25:24 PDT
Created attachment 396654 [details] Patch
Antoine Quint
Comment 2 2020-04-17 08:04:49 PDT
Created attachment 396764 [details] Patch
Daniel Bates
Comment 3 2020-04-17 08:18:27 PDT
Comment on attachment 396764 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396764&action=review This patch looks good. A better patch would add tests for the UA stylesheet changes and the runtime enabled branch. > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:25 > body:-webkit-full-page-media { The optimal solution would remove this because it duplicates the style in html.css now. If it cannot be removed, why?
Antoine Quint
Comment 4 2020-04-17 08:38:20 PDT
(In reply to Daniel Bates from comment #3) > Comment on attachment 396764 [details] > Patch > > > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:25 > > body:-webkit-full-page-media { > > The optimal solution would remove this because it duplicates the style in > html.css now. If it cannot be removed, why? It can, just an oversight!
Antoine Quint
Comment 5 2020-04-17 10:24:30 PDT
Committed r260261: <https://trac.webkit.org/changeset/260261>
Radar WebKit Bug Importer
Comment 6 2020-04-17 10:25:22 PDT
<rdar://problem/61940561>
Ryan Haddad
Comment 7 2020-04-17 11:56:51 PDT
Follow up build fix in https://trac.webkit.org/changeset/260269/webkit
Antoine Quint
Comment 8 2020-04-17 11:59:51 PDT
(In reply to Ryan Haddad from comment #7) > Follow up build fix in https://trac.webkit.org/changeset/260269/webkit Actually, this was for the wrong bug :) This was a bug fix for bug 210653.
Note You need to log in before you can comment on or make changes to this bug.