| Summary: | Stop including style rules related to media controls in the UA style sheet when Modern Media Controls are enabled | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||
| Component: | Media | Assignee: | Antoine Quint <graouts> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | calvaris, eric.carlson, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, jer.noble, koivisto, macpherson, menard, philipj, sergio, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Antoine Quint
2020-04-16 09:23:05 PDT
Created attachment 396654 [details]
Patch
Created attachment 396764 [details]
Patch
Comment on attachment 396764 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396764&action=review This patch looks good. A better patch would add tests for the UA stylesheet changes and the runtime enabled branch. > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:25 > body:-webkit-full-page-media { The optimal solution would remove this because it duplicates the style in html.css now. If it cannot be removed, why? (In reply to Daniel Bates from comment #3) > Comment on attachment 396764 [details] > Patch > > > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:25 > > body:-webkit-full-page-media { > > The optimal solution would remove this because it duplicates the style in > html.css now. If it cannot be removed, why? It can, just an oversight! Committed r260261: <https://trac.webkit.org/changeset/260261> Follow up build fix in https://trac.webkit.org/changeset/260269/webkit (In reply to Ryan Haddad from comment #7) > Follow up build fix in https://trac.webkit.org/changeset/260269/webkit Actually, this was for the wrong bug :) This was a bug fix for bug 210653. |