Bug 210574

Summary: Disable Store-load pair auto-vectorization for JSC
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, ggaren, gyuyoung.kim, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+, ews-feeder: commit-queue-

Keith Miller
Reported 2020-04-15 15:21:02 PDT
Disable Store-load pair auto-vectorization for JSC
Attachments
Patch (2.98 KB, patch)
2020-04-15 15:35 PDT, Keith Miller 		ggaren: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2020-04-15 15:35:47 PDT
Created attachment 396581 [details] Patch
Geoffrey Garen
Comment 2 2020-04-15 15:45:00 PDT
Comment on attachment 396581 [details] Patch r=me Seems like this is worth a bug report for clang/llvm.
EWS
Comment 3 2020-04-15 17:20:06 PDT
Found 4 new test failures: imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/style-change-events.html, imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate.html, imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/target.html, imported/w3c/web-platform-tests/web-animations/interfaces/Animation/commitStyles.html
Keith Miller
Comment 4 2020-04-15 17:21:39 PDT
(In reply to EWS from comment #3) > Found 4 new test failures: > imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/ > style-change-events.html, > imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate. > html, > imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/ > target.html, > imported/w3c/web-platform-tests/web-animations/interfaces/Animation/ > commitStyles.html Huh, how did these fail on CQ but not on EWS? They also don't fail locally...
Keith Miller
Comment 5 2020-04-15 18:45:26 PDT
Committed r260166: <https://trac.webkit.org/changeset/260166>
Radar WebKit Bug Importer
Comment 6 2020-04-15 18:46:13 PDT
<rdar://problem/61862128>
Note You need to log in before you can comment on or make changes to this bug.