Bug 210560

Summary: Add a test to ensure WebKit::mayContainEditableElementsInRect() returns true if the document element is editable
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add a layout test
none
To Land none

Daniel Bates
Reported 2020-04-15 11:36:01 PDT
Add a test to ensure WebKit::mayContainEditableElementsInRect() returns true if <html contenteditable="true">.
Attachments
Add a layout test (2.71 KB, patch)
2020-04-15 11:39 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
To Land (2.62 KB, patch)
2020-04-18 16:17 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2020-04-15 11:39:05 PDT
Created attachment 396554 [details] Add a layout test
Daniel Bates
Comment 2 2020-04-18 09:22:32 PDT
EWS failures are clearly unrelated.
Simon Fraser (smfr)
Comment 3 2020-04-18 16:11:53 PDT
Comment on attachment 396554 [details] Add a layout test View in context: https://bugs.webkit.org/attachment.cgi?id=396554&action=review > LayoutTests/editing/editable-region/hit-test-editable-document-element.html:13 > +if (window.testRunner) > + testRunner.dumpAsText(); You don't need this with a js test.
Daniel Bates
Comment 4 2020-04-18 16:13:13 PDT
Comment on attachment 396554 [details] Add a layout test View in context: https://bugs.webkit.org/attachment.cgi?id=396554&action=review Thanks Simon for the review! >> LayoutTests/editing/editable-region/hit-test-editable-document-element.html:13 >> + testRunner.dumpAsText(); > > You don't need this with a js test. yep, will remove
Daniel Bates
Comment 5 2020-04-18 16:17:12 PDT
Created attachment 396870 [details] To Land
Daniel Bates
Comment 6 2020-04-18 16:17:35 PDT
Committed r260326: <https://trac.webkit.org/changeset/260326>
Radar WebKit Bug Importer
Comment 7 2020-04-18 16:18:14 PDT
<rdar://problem/61987019>
Note You need to log in before you can comment on or make changes to this bug.