| Summary: | Add a test to ensure WebKit::mayContainEditableElementsInRect() returns true if the document element is editable | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||
| Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Daniel Bates
2020-04-15 11:36:01 PDT
Created attachment 396554 [details]
Add a layout test
EWS failures are clearly unrelated. Comment on attachment 396554 [details] Add a layout test View in context: https://bugs.webkit.org/attachment.cgi?id=396554&action=review > LayoutTests/editing/editable-region/hit-test-editable-document-element.html:13 > +if (window.testRunner) > + testRunner.dumpAsText(); You don't need this with a js test. Comment on attachment 396554 [details] Add a layout test View in context: https://bugs.webkit.org/attachment.cgi?id=396554&action=review Thanks Simon for the review! >> LayoutTests/editing/editable-region/hit-test-editable-document-element.html:13 >> + testRunner.dumpAsText(); > > You don't need this with a js test. yep, will remove Created attachment 396870 [details]
To Land
Committed r260326: <https://trac.webkit.org/changeset/260326> |