Summary: | REGRESSION (r259762): Should always hit test for editable elements if the WKWebView is fully editable | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||
Component: | WebKit Misc. | Assignee: | Daniel Bates <dbates> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Local Build | ||||||||
Hardware: | iPhone / iPad | ||||||||
OS: | iOS 13 | ||||||||
Bug Depends on: | 210398 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Daniel Bates
2020-04-15 11:09:32 PDT
Created attachment 396553 [details]
Patch
Comment on attachment 396553 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396553&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:205 > + NSArray<_WKTextInputContext *> *contexts; Nit - maybe just move this down so that it’s `NSArray<_WKTextInputContext *> *contexts = [webView synchronouslyRequestTextInputContextsInRect:[webView bounds]];`? Comment on attachment 396553 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396553&action=review Thanks for the review! >> Tools/TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:205 >> + NSArray<_WKTextInputContext *> *contexts; > > Nit - maybe just move this down so that it’s `NSArray<_WKTextInputContext *> *contexts = [webView synchronouslyRequestTextInputContextsInRect:[webView bounds]];`? I'll just inline [webView synchronouslyRequestTextInputContextsInRect:[webView bounds]] into the EXPECT_GE to get rid of the local altogether. Created attachment 396556 [details]
To Land
Comment on attachment 396556 [details] To Land Clearing flags on attachment: 396556 Committed r260193: <https://trac.webkit.org/changeset/260193> All reviewed patches have been landed. Closing bug. |