Summary: | [GTK4] Fix use of gtk init functions | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | annulen, aperez, bugs-noreply, ews-watchlist, gyuyoung.kim, pnormand, ryuan.choi, sergio | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 210100 | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2020-04-15 08:29:21 PDT
Created attachment 396539 [details]
Patch
Patch doesn't include the plugin process main (because we should disable plugin process in gtk4) and MiniBrowser that should probably use GtkApplication instead.
Committed r260132: <https://trac.webkit.org/changeset/260132> Why was this landed with red EWS? A clean build fails here, same as in the EWS: ../../../Tools/TestWebKitAPI/gtk/main.cpp:29:10: fatal error: 'WebCore/GtkVersioning.h' file not found #include <WebCore/GtkVersioning.h> ^~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. $ find WebKitBuild/GTK/ -name GtkVersioning.h $ (In reply to Philippe Normand from comment #3) > Why was this landed with red EWS? Because I fixed the build error before landing, at least locally. > A clean build fails here, same as in the EWS: > > > ../../../Tools/TestWebKitAPI/gtk/main.cpp:29:10: fatal error: > 'WebCore/GtkVersioning.h' file not found > #include <WebCore/GtkVersioning.h> > ^~~~~~~~~~~~~~~~~~~~~~~~~ > 1 error generated. > > $ find WebKitBuild/GTK/ -name GtkVersioning.h > $ That's different error, we should probably make WebCore a dependency of TestWebKitAPI to ensure the forwarding header is generated before. |