Bug 210550

Summary: [GTK4] Fix use of gtk init functions
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, bugs-noreply, ews-watchlist, gyuyoung.kim, pnormand, ryuan.choi, sergio
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 210100    
Attachments:
Description Flags
Patch aperez: review+

Carlos Garcia Campos
Reported 2020-04-15 08:29:21 PDT
Add gtk_init and gtk_init_check receiving parameters to GtkVersioning
Attachments
Patch (5.66 KB, patch)
2020-04-15 08:33 PDT, Carlos Garcia Campos 		aperez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2020-04-15 08:33:22 PDT
Created attachment 396539 [details] Patch Patch doesn't include the plugin process main (because we should disable plugin process in gtk4) and MiniBrowser that should probably use GtkApplication instead.
Carlos Garcia Campos
Comment 2 2020-04-15 09:06:28 PDT
Committed r260132: <https://trac.webkit.org/changeset/260132>
Philippe Normand
Comment 3 2020-04-16 04:50:59 PDT
Why was this landed with red EWS? A clean build fails here, same as in the EWS: ../../../Tools/TestWebKitAPI/gtk/main.cpp:29:10: fatal error: 'WebCore/GtkVersioning.h' file not found #include <WebCore/GtkVersioning.h> ^~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. $ find WebKitBuild/GTK/ -name GtkVersioning.h $
Carlos Garcia Campos
Comment 4 2020-04-16 05:45:54 PDT
(In reply to Philippe Normand from comment #3) > Why was this landed with red EWS? Because I fixed the build error before landing, at least locally. > A clean build fails here, same as in the EWS: > > > ../../../Tools/TestWebKitAPI/gtk/main.cpp:29:10: fatal error: > 'WebCore/GtkVersioning.h' file not found > #include <WebCore/GtkVersioning.h> > ^~~~~~~~~~~~~~~~~~~~~~~~~ > 1 error generated. > > $ find WebKitBuild/GTK/ -name GtkVersioning.h > $ That's different error, we should probably make WebCore a dependency of TestWebKitAPI to ensure the forwarding header is generated before.
Note You need to log in before you can comment on or make changes to this bug.