| Summary: | not invoked functions | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gabriella Toth <gtoth> | ||||||||||||||
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Trivial | ||||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | PC | ||||||||||||||||
| OS: | All | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 23748 [details]
proposed patch
Comment on attachment 23748 [details]
proposed patch
Some of these should probably have ifdefs around them (like USE(SVG_FILTERS), but I don't think all of these should be deleted. We should address these each with separate patches.
Created attachment 23785 [details]
proposed patch
Created attachment 23786 [details]
proposed patch
Created attachment 23787 [details]
proposed patch
Created attachment 23788 [details]
proposed patch
Created attachment 23789 [details]
proposed patch
Comment on attachment 23789 [details] proposed patch The callOnMainThreadAndWait function was added only 3 weeks ago and it the ground work for future tasks that will use it. r36056 Comment on attachment 23787 [details]
proposed patch
The Document::canReplaceChild method is replaces the base-class Node::canReplaceChild version.
Comment on attachment 23788 [details]
proposed patch
r=me
Comment on attachment 23786 [details]
proposed patch
FrameView::scrollTo() has been recently removed by Hyatt.
Comment on attachment 23788 [details]
proposed patch
Clearing the review flag because this has been landed.
Comment on attachment 23785 [details]
proposed patch
I don't think we should remove AVLTree::start_iter just because it isn't used today.
Ok. It can be closed. |
I performed static source code analysis on WebKit and found 6 functions which are not invoked at all, therefore they can be deleted. The list of functions: * start_iter (JavaScriptCore/wtf/AVLTree.h, line: 168, Lines of Code (LOC) = 49) * setStandardAttributes (WebCore/svg/SVGFilterPrimitiveStandardAttributes.cpp, line: 72, LOC = 53) * scrollTo (WebCore/page/FrameView.cpp, line 565, LOC = 64) * canReplaceChild (WebCore/dom/Document.cpp, line 2002, LOC = 84) * statementListInitializeVariableAccessStack (JavaScriptCore/kjs/nodes.cpp, line 1103, LOC = 16) * callOnMainThreadAndWait (JavaScriptCore/wtf/MainThread.cpp, line 106, LOC = 21)