Bug 210533

Summary: SPI clients using fastServerTrustEvaluationEnabled need SPI to inform them of modern TLS negotiation
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 210825    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2020-04-14 23:18:42 PDT
SPI clients using fastServerTrustEvaluationEnabled need SPI to inform them of modern TLS negotiation
Attachments
Patch (19.93 KB, patch)
2020-04-14 23:19 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (19.95 KB, patch)
2020-04-20 19:36 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (19.92 KB, patch)
2020-04-24 10:38 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-04-14 23:19:52 PDT
Created attachment 396504 [details] Patch
EWS
Comment 2 2020-04-20 19:29:11 PDT
Tools/Scripts/svn-apply failed to apply attachment 396504 [details] to trunk. Please resolve the conflicts and upload a new patch.
Alex Christensen
Comment 3 2020-04-20 19:36:26 PDT
Created attachment 397047 [details] Patch
EWS
Comment 4 2020-04-20 20:23:58 PDT
Committed r260410: <https://trac.webkit.org/changeset/260410> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397047 [details].
Radar WebKit Bug Importer
Comment 5 2020-04-20 20:25:28 PDT
<rdar://problem/62088873>
Ryan Haddad
Comment 6 2020-04-21 20:58:41 PDT
Reverted r260410 for reason: Caused crashes in Safari Committed r260497: <https://trac.webkit.org/changeset/260497>
Ryan Haddad
Comment 7 2020-04-21 20:59:33 PDT
(In reply to Ryan Haddad from comment #6) > Reverted r260410 for reason: > > Caused crashes in Safari > > Committed r260497: <https://trac.webkit.org/changeset/260497> Reverted because I had to had to revert https://bugs.webkit.org/show_bug.cgi?id=210825, which was a follow-up fix for this change.
Alex Christensen
Comment 8 2020-04-24 10:36:05 PDT
Comment on attachment 397047 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397047&action=review > Source/WebKit/NetworkProcess/NetworkLoad.cpp:291 > + m_networkProcess->send(Messages::NetworkProcessProxy::DidNegotiateModernTLS(m_parameters.webPageProxyID, challenge)); I'm adding if (m_parameters.webPageProxyID) here. We should later make sure that's always true.
Alex Christensen
Comment 9 2020-04-24 10:38:05 PDT
Created attachment 397469 [details] Patch
EWS
Comment 10 2020-04-24 11:23:48 PDT
Committed r260658: <https://trac.webkit.org/changeset/260658> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397469 [details].
Note You need to log in before you can comment on or make changes to this bug.