Bug 210825 – REGRESSION(r260410) Frequent Network process crashes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Frequent Network process crashes due to bad IPC:
Received an invalid message ‘NetworkProcessProxy::DidNegotiateModernTLS’ from the Networking process.

[Chris Dumez]

Created attachment 397140 [details]
Patch

[Chris Dumez]

<rdar://problem/62133579>

[EWS]

Committed r260475: <https://trac.webkit.org/changeset/260475>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397140 [details].

[Ryan Haddad]

(In reply to EWS from comment #3)
> Committed r260475: <https://trac.webkit.org/changeset/260475>
The assert added with this change is causing macOS layout test and API test failures

ASSERTION FAILED: m_parameters.webPageProxyID
/Volumes/Data/slave/catalina-debug/build/Source/WebKit/NetworkProcess/NetworkLoad.cpp(66) : WebKit::NetworkLoad::NetworkLoad(WebKit::NetworkLoadClient &, WebCore::BlobRegistryImpl *, WebKit::NetworkLoadParameters &&, WebKit::NetworkSession &)

See: https://build.webkit.org/builders/Apple-Catalina-Debug-WK2-Tests/builds/3714

[Ryan Haddad]

Reverted r260475 for reason:

New assert caused layout tests to exit early on iOS and macOS

Committed r260496: <https://trac.webkit.org/changeset/260496>

[Diego Pino]

Also happening in WebKitGTK+.

STDERR: ASSERTION FAILED: m_parameters.webPageProxyID
STDERR: ../../Source/WebKit/NetworkProcess/NetworkLoad.cpp(66) : WebKit::NetworkLoad::NetworkLoad(WebKit::NetworkLoadClient&, WebCore::BlobRegistryImpl*, WebKit::NetworkLoadParameters&&, WebKit::NetworkSession&)

See: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Tests%29/builds/6181

[Chris Dumez]

Closing since patch that caused this was reverted.