Bug 210532

Summary:

isNullFunctionPointer() can fail for symbols not explicitly marked as weakly linked.

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mitz, sam, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Jer Noble 2020-04-14 22:03:52 PDT

isNullFunctionPointer() can fail for symbols not explicitly marked as weakly linked.

Comment 1 Jer Noble 2020-04-14 22:11:47 PDT

Created attachment 396499 [details]
Patch

Comment 2 EWS 2020-04-15 08:32:25 PDT

Committed r260129: <https://trac.webkit.org/changeset/260129>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396499 [details].

Comment 3 Radar WebKit Bug Importer 2020-04-15 08:33:14 PDT

<rdar://problem/61829150>

Comment 4 Sam Weinig 2020-04-15 08:45:19 PDT

I don't think this is the right approach for this. If we are going to change libWebRTC, I think we should add a non-function symbol to use to check weak-linkage.  And we should remove isNullFunctionPointer() or fix it it, but not leave it half working (see https://bugs.webkit.org/show_bug.cgi?id=208873)