Summary: | Data Detected Actions sheets are presented from odd locations. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||||
Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | thorton, webkit-bug-importer, wenson_hsieh | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Megan Gardner
2020-04-14 21:50:17 PDT
Created attachment 396498 [details]
Patch
Comment on attachment 396498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396498&action=review > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:757 > + if ([delegate respondsToSelector:@selector(_createTargetedContextMenuHintPreviewIfPossible)]) > + return [delegate _createTargetedContextMenuHintPreviewIfPossible]; Is this not important for other clients of WKActionSheetAssistant (whoever they are? WKPDFView?) Comment on attachment 396498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396498&action=review > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h:66 > +- (UITargetedPreview *)_createTargetedContextMenuHintPreviewIfPossible; Nit - delegate methods usually take the object that’s calling into the delegate as an argument. Comment on attachment 396498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396498&action=review > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h:66 > +- (UITargetedPreview *)_createTargetedContextMenuHintPreviewIfPossible; where's the parameter indicating which action sheet assistant the delegate should respond for? Created attachment 396543 [details]
Patch
Comment on attachment 396543 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396543&action=review > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:757 > + if ([delegate respondsToSelector:@selector(createTargetedContextMenuHintForAcitionSheetAssistant:)]) > + return [delegate createTargetedContextMenuHintForAcitionSheetAssistant:self]; Nit - “Acition" Created attachment 396552 [details]
Patch for landing
Found 4 new test failures: imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/style-change-events.html, imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate.html, imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/target.html, imported/w3c/web-platform-tests/web-animations/interfaces/Animation/commitStyles.html Committed r260146: <https://trac.webkit.org/changeset/260146> |