Bug 210531

Summary: Data Detected Actions sheets are presented from odd locations.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing ews-feeder: commit-queue-

Megan Gardner
Reported 2020-04-14 21:50:17 PDT
Data Detected Actions sheets are presented from odd locations.
Attachments
Patch (4.30 KB, patch)
2020-04-14 21:51 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (4.77 KB, patch)
2020-04-15 09:47 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.76 KB, patch)
2020-04-15 11:19 PDT, Megan Gardner 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2020-04-14 21:51:44 PDT
Created attachment 396498 [details] Patch
Tim Horton
Comment 2 2020-04-14 21:56:33 PDT
Comment on attachment 396498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396498&action=review > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:757 > + if ([delegate respondsToSelector:@selector(_createTargetedContextMenuHintPreviewIfPossible)]) > + return [delegate _createTargetedContextMenuHintPreviewIfPossible]; Is this not important for other clients of WKActionSheetAssistant (whoever they are? WKPDFView?)
Wenson Hsieh
Comment 3 2020-04-14 21:57:30 PDT
Comment on attachment 396498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396498&action=review > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h:66 > +- (UITargetedPreview *)_createTargetedContextMenuHintPreviewIfPossible; Nit - delegate methods usually take the object that’s calling into the delegate as an argument.
Tim Horton
Comment 4 2020-04-14 21:57:45 PDT
Comment on attachment 396498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396498&action=review > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h:66 > +- (UITargetedPreview *)_createTargetedContextMenuHintPreviewIfPossible; where's the parameter indicating which action sheet assistant the delegate should respond for?
Megan Gardner
Comment 5 2020-04-15 09:47:41 PDT
Created attachment 396543 [details] Patch
Wenson Hsieh
Comment 6 2020-04-15 10:12:06 PDT
Comment on attachment 396543 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396543&action=review > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:757 > + if ([delegate respondsToSelector:@selector(createTargetedContextMenuHintForAcitionSheetAssistant:)]) > + return [delegate createTargetedContextMenuHintForAcitionSheetAssistant:self]; Nit - “Acition"
Megan Gardner
Comment 7 2020-04-15 11:19:45 PDT
Created attachment 396552 [details] Patch for landing
EWS
Comment 8 2020-04-15 12:57:15 PDT
Found 4 new test failures: imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/style-change-events.html, imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate.html, imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/target.html, imported/w3c/web-platform-tests/web-animations/interfaces/Animation/commitStyles.html
Megan Gardner
Comment 9 2020-04-15 13:20:32 PDT
Committed r260146: <https://trac.webkit.org/changeset/260146>
Radar WebKit Bug Importer
Comment 10 2020-04-15 13:21:20 PDT
<rdar://problem/61844617>
Note You need to log in before you can comment on or make changes to this bug.