| Summary: | Move ApplePay code from WebKitAdditions to WebCore and WebKit | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||
| Severity: | Normal | CC: | aestes, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer | ||||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||
|
Description
Alex Christensen
2020-04-14 16:11:43 PDT
Created attachment 396473 [details]
Patch
Created attachment 396475 [details]
Patch
Created attachment 396477 [details]
Patch
Created attachment 396479 [details]
Patch
Created attachment 396480 [details]
Patch
Created attachment 396483 [details]
Patch
Created attachment 396487 [details]
Patch
Created attachment 396489 [details]
Patch
Created attachment 396495 [details]
Patch
Created attachment 396496 [details]
Patch
Created attachment 396505 [details]
Patch
Hooray! I got all EWS green. This needs to be landed at the same time as removing the internal files to not break the internal build, so I'll do this late at night. Comment on attachment 396505 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396505&action=review > Source/WebCore/DerivedSources.make:-1258 > --include WebCoreDerivedSourcesAdditions.make This is still needed. I won't remove it. This is super tricky to do without renaming all the new files because internal SDKs have all the files in them and they are included. I think I'll have to put a prefix on all the new files. Created attachment 397593 [details]
Patch
Corresponding internal change ef405149415e6e6f7df4758f25f06befdff410a1 |