Summary: | Content expanding is broken on icourse163.org | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, cdumez, darin, esprehn+autocc, ews-watchlist, kangil.han, simon.fraser, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 254906 | ||||||||
Attachments: |
|
Description
zalan
2020-04-14 12:26:33 PDT
Created attachment 396449 [details]
Patch
needs quirk test Comment on attachment 396449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396449&action=review > Source/WebCore/page/Quirks.cpp:166 > + // www.icourse163.org's animation code expects a decimal point in the rAF timestamp (millisecond resolution). This should reference the radar number, rather than have this comment here I think. Comment on attachment 396449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396449&action=review >> Source/WebCore/page/Quirks.cpp:166 >> + // www.icourse163.org's animation code expects a decimal point in the rAF timestamp (millisecond resolution). > > This should reference the radar number, rather than have this comment here I think. You mean WebKit bugs.webkit.org bug number? (In reply to Darin Adler from comment #5) > Comment on attachment 396449 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=396449&action=review > > >> Source/WebCore/page/Quirks.cpp:166 > >> + // www.icourse163.org's animation code expects a decimal point in the rAF timestamp (millisecond resolution). > > > > This should reference the radar number, rather than have this comment here I think. > > You mean WebKit bugs.webkit.org bug number? If we're fine with the quirk being public, sure. Enough to track it down in future if we need to know if we can remove the quirk. Created attachment 396490 [details]
Patch
Committed r260114: <https://trac.webkit.org/changeset/260114> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396490 [details]. *** Bug 210527 has been marked as a duplicate of this bug. *** |