| Summary: | Make WTR::AccessibilityUIElements calls to accessibilitySetValue run on AX secondary thread. web content | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||
| Component: | New Bugs | Assignee: | Andres Gonzalez <andresg_22> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Andres Gonzalez
2020-04-14 09:00:40 PDT
Created attachment 396422 [details]
Patch
Comment on attachment 396422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396422&action=review > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:1479 > + NSArray* selectedChildren = attributeValue(m_element.get(), NSAccessibilitySelectedChildrenAttribute); objectiveC pointers actually supposed to stay on the right side of the space Created attachment 396438 [details]
Patch
(In reply to chris fleizach from comment #2) > Comment on attachment 396422 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=396422&action=review > > > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:1479 > > + NSArray* selectedChildren = attributeValue(m_element.get(), NSAccessibilitySelectedChildrenAttribute); > > objectiveC pointers actually supposed to stay on the right side of the space Fixed this one and a few other instances. Thanks. Committed r260083: <https://trac.webkit.org/changeset/260083> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396438 [details]. |