Bug 210500

Summary: Make WTR::AccessibilityUIElements calls to accessibilitySetValue run on AX secondary thread. web content
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andres Gonzalez
Reported 2020-04-14 09:00:40 PDT
Make WTR::AccessibilityUIElements calls to accessibilitySetValue run on AX secondary thread. web content
Attachments
Patch (17.76 KB, patch)
2020-04-14 09:09 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (18.30 KB, patch)
2020-04-14 11:03 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2020-04-14 09:09:48 PDT
Created attachment 396422 [details] Patch
chris fleizach
Comment 2 2020-04-14 09:13:59 PDT
Comment on attachment 396422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396422&action=review > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:1479 > + NSArray* selectedChildren = attributeValue(m_element.get(), NSAccessibilitySelectedChildrenAttribute); objectiveC pointers actually supposed to stay on the right side of the space
Andres Gonzalez
Comment 3 2020-04-14 11:03:03 PDT
Created attachment 396438 [details] Patch
Andres Gonzalez
Comment 4 2020-04-14 11:05:13 PDT
(In reply to chris fleizach from comment #2) > Comment on attachment 396422 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=396422&action=review > > > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:1479 > > + NSArray* selectedChildren = attributeValue(m_element.get(), NSAccessibilitySelectedChildrenAttribute); > > objectiveC pointers actually supposed to stay on the right side of the space Fixed this one and a few other instances. Thanks.
EWS
Comment 5 2020-04-14 11:48:31 PDT
Committed r260083: <https://trac.webkit.org/changeset/260083> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396438 [details].
Radar WebKit Bug Importer
Comment 6 2020-04-14 11:49:13 PDT
<rdar://problem/61783089>
Note You need to log in before you can comment on or make changes to this bug.