| Summary: | Remove downloadAttribute from DocumentLoader | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||
| Component: | New Bugs | Assignee: | Rob Buis <rbuis> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, cdumez, darin, ews-watchlist, japhet, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Safari Technology Preview | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Rob Buis
2020-04-14 06:59:12 PDT
Created attachment 396411 [details]
Patch
Comment on attachment 396411 [details] Patch Alex, in https://bugs.webkit.org/show_bug.cgi?id=196755 you passed in loadPostRequest the frameLoadRequest download attribute into the NavigationAction but passed { } to store that for download attribute into the DocumentLoader. Was that intentional? This removal patch can only work in case both values are the same or in case the value does not matter for POST. Also are there tests or should this be manually checked? If the unit test from bug 196755 still passes, then this works. (In reply to Alex Christensen from comment #3) > If the unit test from bug 196755 still passes, then this works. Thanks for the hint! Yes, it passes with the patch. Committed r260843: <https://trac.webkit.org/changeset/260843> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396411 [details]. |