RESOLVED FIXED210493
Remove downloadAttribute from DocumentLoader 
https://bugs.webkit.org/show_bug.cgi?id=210493
Summary Remove downloadAttribute from DocumentLoader
Rob Buis
Reported 2020-04-14 06:59:12 PDT
Remove downloadAttribute from DocumentLoader since this value can be obtained from the NavigationAction.
Attachments
Patch (7.92 KB, patch)
2020-04-14 07:01 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-04-14 07:01:55 PDT
Created attachment 396411 [details] Patch
Rob Buis
Comment 2 2020-04-14 07:49:33 PDT
Comment on attachment 396411 [details] Patch Alex, in https://bugs.webkit.org/show_bug.cgi?id=196755 you passed in loadPostRequest the frameLoadRequest download attribute into the NavigationAction but passed { } to store that for download attribute into the DocumentLoader. Was that intentional? This removal patch can only work in case both values are the same or in case the value does not matter for POST. Also are there tests or should this be manually checked?
Alex Christensen
Comment 3 2020-04-28 09:26:00 PDT
If the unit test from bug 196755 still passes, then this works.
Rob Buis
Comment 4 2020-04-28 13:33:52 PDT
(In reply to Alex Christensen from comment #3) > If the unit test from bug 196755 still passes, then this works. Thanks for the hint! Yes, it passes with the patch.
EWS
Comment 5 2020-04-28 13:41:40 PDT
Committed r260843: <https://trac.webkit.org/changeset/260843> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396411 [details].
Radar WebKit Bug Importer
Comment 6 2020-04-28 13:42:13 PDT
<rdar://problem/62542589>
Note You need to log in before you can comment on or make changes to this bug.