Bug 210493 - Remove downloadAttribute from DocumentLoader
Summary: Remove downloadAttribute from DocumentLoader
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-14 06:59 PDT by Rob Buis
Modified: 2020-04-28 13:42 PDT (History)
6 users (show)

See Also:

Attachments
Patch (7.92 KB, patch)
2020-04-14 07:01 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-04-14 06:59:12 PDT 
Remove downloadAttribute from DocumentLoader since this value can
be obtained from the NavigationAction.
Comment 1 Rob Buis 2020-04-14 07:01:55 PDT 
Created attachment 396411 [details]
Patch
Comment 2 Rob Buis 2020-04-14 07:49:33 PDT 
Comment on attachment 396411 [details]
Patch

Alex, in https://bugs.webkit.org/show_bug.cgi?id=196755 you passed in loadPostRequest the frameLoadRequest download attribute into the NavigationAction but passed { } to store that for download attribute into the DocumentLoader. Was that intentional? This removal patch can only work in case both values are the same or in case the value does not matter for POST.
Also are there tests or should this be manually checked?
Comment 3 Alex Christensen 2020-04-28 09:26:00 PDT 
If the unit test from bug 196755 still passes, then this works.
Comment 4 Rob Buis 2020-04-28 13:33:52 PDT 
(In reply to Alex Christensen from comment #3)
> If the unit test from bug 196755 still passes, then this works.

Thanks for the hint! Yes, it passes with the patch.
Comment 5 EWS 2020-04-28 13:41:40 PDT 
Committed r260843: <https://trac.webkit.org/changeset/260843>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396411 [details].
Comment 6 Radar WebKit Bug Importer 2020-04-28 13:42:13 PDT 
<rdar://problem/62542589>