| Summary: | Opacity fails in multicolumn layouts | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Raboczi <srab8378> | ||||||||||
| Component: | CSS | Assignee: | Dave Hyatt <hyatt> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | abarth, eric, garrett, hyatt, simon.fraser, webkit, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Mac | ||||||||||||
| OS: | OS X 10.5 | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 23741 [details]
HTML markup demonstrating different behavior of opacity in second column
*** Bug 27069 has been marked as a duplicate of this bug. *** Created attachment 32454 [details]
Screenshot of multi-col with Opacity:.8 links.
Attached screenshot shows how webkit renders 1 column, then splits it up. Elements with opacity display as if they were in that one column.
*** Bug 27761 has been marked as a duplicate of this bug. *** r59513 has made this better in that if the content is all contained in a single column it will behave correctly. If it spans multiple columns, however, then it won't render correctly yet. *** Bug 25455 has been marked as a duplicate of this bug. *** Created attachment 56462 [details]
Patch
Attachment 56462 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/rendering/RenderLayer.cpp:2549: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
WebCore/rendering/RenderLayer.cpp:2996: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 2 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 56467 [details]
Patch
Comment on attachment 56467 [details]
Patch
r=me
I did like the factoring out of hit test and painting logic for the various renderer lists
Fixed. http://trac.webkit.org/changeset/59784 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/59784 http://trac.webkit.org/changeset/59785 http://trac.webkit.org/changeset/59783 |
In all but the first column of a multicolumn layout, an opacity less than 1 is displayed as 0. The following markup demonstrates this behavior: <html> <head> <style> body { -webkit-column-count: 2 } div { height: 5000 } span { opacity: 0.5 } </style> </head> <body> <div>Left <span>is dim.</span></div> <div>Right <span>is invisible.</span></div> </body> </html>