Summary: | YouTube sometimes navigates unexpectedly when invoking a context menu on a video link. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||||
Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | thorton, wenson_hsieh | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Megan Gardner
2020-04-13 16:53:59 PDT
Created attachment 396358 [details]
Patch
Comment on attachment 396358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396358&action=review At all possible to test? > Source/WebKit/ChangeLog:3 > + TouchEvents not cancelled soon enough in the life of a ContextMenu Gesture, causing TouchEvents and ContextMenus to fire at the same time. How about "YouTube sometimes navigates unexpectedly when invoking a context menu on a video link" for the title. > Source/WebKit/ChangeLog:9 > + We need to cancel the touch events gesture when we are cleaing out things to make way for the ContextMenu Gesture and related events. And some more words here. And no "cleaing out things". Maybe something like: "Cancel any outstanding touches tracked by WebTouchEventsGestureRecognizer, so that we dispatch `touchcancel` to the page instead of `touchend`, so that the page does not misinterpret context menu invocation as a tap." Created attachment 396362 [details]
Patch
Created attachment 396425 [details]
Patch for landing
Committed r260077: <https://trac.webkit.org/changeset/260077> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396425 [details]. |