Bug 210459

Summary: check-webkit-style should warn about attributes that appear after function definitions
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, darin, ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210336
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2020-04-13 15:06:32 PDT
check-webkit-style should warn about attributes that appear after function definitions. Darin suggested it was better to be consistent and always put attributes before the function definition since placing them after the function definition (e.g., in a static function with no predeclaration) doesn't work.
Attachments
Patch v1 (4.87 KB, patch)
2020-04-13 15:14 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2020-04-13 15:14:41 PDT
Created attachment 396339 [details] Patch v1
EWS
Comment 2 2020-04-13 17:32:30 PDT
Committed r260051: <https://trac.webkit.org/changeset/260051> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396339 [details].
Radar WebKit Bug Importer
Comment 3 2020-04-13 17:33:15 PDT
<rdar://problem/61747702>
Note You need to log in before you can comment on or make changes to this bug.