Bug 210440

Summary: Remove the "IgnoreViewportScalingConstraints" debug WebKit feature
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, darin, ddkilzer, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Wenson Hsieh
Reported 2020-04-13 10:35:06 PDT
SSIA.
Attachments
Patch (5.86 KB, patch)
2020-04-13 10:42 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (1.70 KB, patch)
2020-04-13 14:41 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-04-13 10:42:37 PDT
Created attachment 396307 [details] Patch
EWS
Comment 2 2020-04-13 12:42:38 PDT
Committed r260035: <https://trac.webkit.org/changeset/260035> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396307 [details].
Darin Adler
Comment 3 2020-04-13 14:20:55 PDT
Comment on attachment 396307 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396307&action=review > Source/WebKit/UIProcess/API/C/WKPreferences.cpp:1612 > void WKPreferencesSetIgnoreViewportScalingConstraints(WKPreferencesRef preferencesRef, bool enabled) Best to omit or comment out unused argument names. > Source/WebKit/UIProcess/API/C/WKPreferences.cpp:1617 > bool WKPreferencesGetIgnoreViewportScalingConstraints(WKPreferencesRef preferencesRef) Ditto.
Wenson Hsieh
Comment 4 2020-04-13 14:41:26 PDT
Reopening to attach new patch.
Wenson Hsieh
Comment 5 2020-04-13 14:41:27 PDT
Created attachment 396332 [details] Patch
EWS
Comment 6 2020-04-14 10:17:50 PDT
Committed r260080: <https://trac.webkit.org/changeset/260080> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396332 [details].
Note You need to log in before you can comment on or make changes to this bug.