Bug 210427

Summary: Fix clang static analyzer warnings about unused instance variables in WebIconDatabase, WKView
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit APIAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, benjamin, cdumez, cmarcelo, darin, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://clang-analyzer.llvm.org/faq.html#unused_ivar
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2020-04-13 08:15:18 PDT
Fix clang static analyzer warnings about unused instance variables in WebIconDatabase, WKView.

Documentation says that __attribute__((unused)) should be used for this purpose:
<https://clang-analyzer.llvm.org/faq.html#unused_ivar>

Note that __attribute__((unused)) is already defined as UNUSED_FUNCTION in Compiler.h, but it's used for a different purpose: to denote unused parameters in a function definition in these source files:

Source/WTF/wtf/AggregateLogger.h
Source/WTF/wtf/Logger.h
Comment 1 David Kilzer (:ddkilzer) 2020-04-13 08:20:19 PDT
Created attachment 396283 [details]
Patch v1
Comment 2 EWS 2020-04-13 10:53:56 PDT
Committed r260027: <https://trac.webkit.org/changeset/260027>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396283 [details].
Comment 3 Radar WebKit Bug Importer 2020-04-13 10:54:18 PDT
<rdar://problem/61725350>