| Summary: | Change the layout of the JS call frame | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> | ||||
| Component: | JavaScriptCore | Assignee: | Geoffrey Garen <ggaren> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Mac | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Geoffrey Garen
2008-09-23 15:02:06 PDT
Created attachment 23731 [details]
patch
Comment on attachment 23731 [details]
patch
r=me
Comment on attachment 23731 [details]
patch
+#if ENABLE(CTI)
+ALWAYS_INLINE static Instruction* vPCForPC(CodeBlock* codeBlock, void* pc)
Missing blank line here.
+ ArgumentsData(JSActivation* activation, unsigned numParameters, unsigned firstParameterIndex, unsigned numArguments)
firstParameterIndex needs to be int, not unsigned, as you explained to me.
You should un-move all those mark() functions. It's gratuitous.
+ static const unsigned kReadOnlyFlag = 0x1;
+ static const unsigned kDontEnumFlag = 0x2;
+ static const unsigned kNotNullFlag = 0x4;
+ static const unsigned kFlagBits = 3;
I don't agree that we should use "k" for these. We mostly just use capital letters for these without a prefix.
-#if !defined(ENABLE_DASHBOARD_SUPPORT)
-#define ENABLE_DASHBOARD_SUPPORT 0
-#endif
This is fine. Just be sure to land it separately.
r=me
Committed revision 36821. |