Bug 21042 - Change the layout of the JS call frame
Summary: Change the layout of the JS call frame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-23 15:02 PDT by Geoffrey Garen
Modified: 2008-09-23 18:51 PDT (History)
0 users

See Also:

Attachments
patch (deleted)
2008-09-23 15:10 PDT, Geoffrey Garen 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2008-09-23 15:02:06 PDT 
Patch coming.
Comment 1 Geoffrey Garen 2008-09-23 15:10:32 PDT 
Created attachment 23731 [details]
patch
Comment 2 Oliver Hunt 2008-09-23 16:15:31 PDT 
Comment on attachment 23731 [details]
patch

r=me
Comment 3 Darin Adler 2008-09-23 16:56:49 PDT 
Comment on attachment 23731 [details]
patch

+#if ENABLE(CTI)
+ALWAYS_INLINE static Instruction* vPCForPC(CodeBlock* codeBlock, void* pc)

Missing blank line here.

+    ArgumentsData(JSActivation* activation, unsigned numParameters, unsigned firstParameterIndex, unsigned numArguments)

firstParameterIndex needs to be int, not unsigned, as you explained to me.

You should un-move all those mark() functions. It's gratuitous.

+        static const unsigned kReadOnlyFlag = 0x1;
+        static const unsigned kDontEnumFlag = 0x2;
+        static const unsigned kNotNullFlag = 0x4;
+        static const unsigned kFlagBits = 3;

I don't agree that we should use "k" for these. We mostly just use capital letters for these without a prefix.

-#if !defined(ENABLE_DASHBOARD_SUPPORT)
-#define ENABLE_DASHBOARD_SUPPORT 0
-#endif

This is fine. Just be sure to land it separately.

r=me
Comment 4 Geoffrey Garen 2008-09-23 17:27:35 PDT 
Committed revision 36821.