Summary: | Add WARN_UNUSED_RETURN to decode methods in Source/WebCore | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | WebCore Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, achristensen, alecflett, beidson, benjamin, berto, calvaris, cdumez, cgarcia, darin, eric.carlson, esprehn+autocc, ews-watchlist, galpeter, glenn, gustavo, hta, japhet, jer.noble, jsbell, kangil.han, kondapallykalyan, mifenton, pdr, philipj, sergio, tommyw, toyoshim, useafterfree, webkit-bug-importer, yutak | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=209917 | ||||||
Bug Depends on: | 210414 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2020-04-12 20:22:16 PDT
NOTE: Not every change is relate to CoreIPC decoding, but they're all decode methods that return bool. Created attachment 396251 [details]
Patch v1
(In reply to David Kilzer (:ddkilzer) from comment #3) > Created attachment 396251 [details] > Patch v1 I made some change to GTK files, so letting EWS run before requesting review. Heh, this is blocked on Bug 210414 since that fixes a few issues found with these changes. Note: No issues were found. This is to add WARN_UNUSED_RETURN to decode methods returning `bool` to prevent future bugs. Comment on attachment 396251 [details] Patch v1 Obsoleting so I can repost the patch. :( Bug 209917: [ER] Add a way to retry EWS by rebuilding with a newer commit (In reply to David Kilzer (:ddkilzer) from comment #7) > Comment on attachment 396251 [details] > Patch v1 > > Obsoleting so I can repost the patch. :( > > Bug 209917: [ER] Add a way to retry EWS by rebuilding with a newer commit Aakash marked the patch for retry by EWS, so now this patch is ready for review. Committed r260078: <https://trac.webkit.org/changeset/260078> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396251 [details]. |