Bug 210416

Summary:

Add WARN_UNUSED_RETURN to decode methods in Source/WebCore

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

WebCore Misc.

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, achristensen, alecflett, beidson, benjamin, berto, calvaris, cdumez, cgarcia, darin, eric.carlson, esprehn+autocc, ews-watchlist, galpeter, glenn, gustavo, hta, japhet, jer.noble, jsbell, kangil.han, kondapallykalyan, mifenton, pdr, philipj, sergio, tommyw, toyoshim, useafterfree, webkit-bug-importer, yutak

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=209917

Bug Depends on:

210414

Bug Blocks:

Attachments:

Description	Flags
Patch v1	none

David Kilzer (:ddkilzer)

Reported 2020-04-12 20:22:16 PDT

Add WARN_UNUSED_RETURN to decode methods in Source/WebCore. Found via: $ ./Tools/Scripts/check-webkit-style --filter=-,+security/missing_warn_unused_return Source/WebCore

Attachments
Patch v1 (50.04 KB, patch) 2020-04-12 20:30 PDT, David Kilzer (:ddkilzer)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2020-04-12 20:22:52 PDT

NOTE: Not every change is relate to CoreIPC decoding, but they're all decode methods that return bool.

Radar WebKit Bug Importer

Comment 2 2020-04-12 20:25:11 PDT

<rdar://problem/61693462>

David Kilzer (:ddkilzer)

Comment 3 2020-04-12 20:30:53 PDT

Created attachment 396251 [details] Patch v1

David Kilzer (:ddkilzer)

Comment 4 2020-04-12 20:31:29 PDT

(In reply to David Kilzer (:ddkilzer) from comment #3) > Created attachment 396251 [details] > Patch v1 I made some change to GTK files, so letting EWS run before requesting review.

David Kilzer (:ddkilzer)

Comment 5 2020-04-12 20:36:57 PDT

Heh, this is blocked on Bug 210414 since that fixes a few issues found with these changes.

David Kilzer (:ddkilzer)

Comment 6 2020-04-13 07:39:03 PDT

Note: No issues were found. This is to add WARN_UNUSED_RETURN to decode methods returning `bool` to prevent future bugs.

David Kilzer (:ddkilzer)

Comment 7 2020-04-13 11:04:49 PDT

Comment on attachment 396251 [details] Patch v1 Obsoleting so I can repost the patch. :( Bug 209917: [ER] Add a way to retry EWS by rebuilding with a newer commit

David Kilzer (:ddkilzer)

Comment 8 2020-04-13 11:21:50 PDT

(In reply to David Kilzer (:ddkilzer) from comment #7) > Comment on attachment 396251 [details] > Patch v1 > > Obsoleting so I can repost the patch. :( > > Bug 209917: [ER] Add a way to retry EWS by rebuilding with a newer commit Aakash marked the patch for retry by EWS, so now this patch is ready for review.

EWS

Comment 9 2020-04-14 10:03:31 PDT

Committed r260078: <https://trac.webkit.org/changeset/260078> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396251 [details].

Note You need to log in before you can comment on or make changes to this bug.