Bug 210414

Summary: KeyedDecoder functions in ResourceLoadStatistics.{cpp,h} should return bool and use WARN_UNUSED_RETURN
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebCore Misc.Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED INVALID    
Severity: Normal CC: achristensen, bfulgham, cdumez, darin, ews-watchlist, japhet, katherine_cheney, webkit-bug-importer, wilander, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 212422, 212424    
Bug Blocks: 210416, 212423    
Attachments:
Description Flags
Patch v1
none
Patch v2
none
Patch v4 none

David Kilzer (:ddkilzer)
Reported 2020-04-12 20:13:22 PDT
KeyedDecoder functions in ResourceLoadStatistics.{cpp,h} should return bool and use WARN_UNUSED_RETURN. Found via: $ ./Tools/Scripts/check-webkit-style --filter=-,+security/missing_warn_unused_return Source/WebCore/loader/ResourceLoadStatistics.*
Attachments
Patch v1 (13.66 KB, patch)
2020-04-12 20:18 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Patch v2 (deleted)
2020-05-27 13:07 PDT, David Kilzer (:ddkilzer) 		no flags
Details
Patch v4 (deleted)
2020-05-27 15:38 PDT, David Kilzer (:ddkilzer) 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-04-12 20:14:00 PDT
<rdar://problem/61693118>
David Kilzer (:ddkilzer)
Comment 2 2020-04-12 20:18:48 PDT
Created attachment 396250 [details] Patch v1
EWS
Comment 3 2020-04-13 10:41:48 PDT
Committed r260023: <https://trac.webkit.org/changeset/260023> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396250 [details].
Yusuke Suzuki
Comment 4 2020-05-27 11:36:46 PDT
Re-opened since this is blocked by bug 212422
David Kilzer (:ddkilzer)
Comment 5 2020-05-27 13:07:39 PDT
Created attachment 400368 [details] Patch v2
David Kilzer (:ddkilzer)
Comment 6 2020-05-27 13:10:37 PDT
The content of attachment 400368 [details] has been deleted for the following reason: Uploaded to wrong bug (was for Bug 212424).
David Kilzer (:ddkilzer)
Comment 7 2020-05-27 13:11:57 PDT
This will be fixed a different way in the future.
David Kilzer (:ddkilzer)
Comment 8 2020-05-27 15:38:40 PDT
Reopening to attach new patch.
David Kilzer (:ddkilzer)
Comment 9 2020-05-27 15:38:41 PDT
Created attachment 400393 [details] Patch v4
David Kilzer (:ddkilzer)
Comment 10 2020-05-27 15:39:37 PDT
The content of attachment 400393 [details] has been deleted for the following reason: Uploaded to wrong bug (was for Bug 212424).
Note You need to log in before you can comment on or make changes to this bug.