Bug 210318

Summary: Hit-testing a WebTiledBackingLayer with an animation asserts
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Simon Fraser (smfr)
Reported 2020-04-09 20:46:11 PDT
Hit-testing a WebTiledBackingLayer with an animation asserts
Attachments
Patch (5.45 KB, patch)
2020-04-09 20:47 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (5.47 KB, patch)
2020-04-09 20:56 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (5.47 KB, patch)
2020-04-09 21:02 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-04-09 20:47:58 PDT
Created attachment 396040 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-04-09 20:48:22 PDT
<rdar://problem/61561048>
Simon Fraser (smfr)
Comment 3 2020-04-09 20:56:32 PDT
Created attachment 396041 [details] Patch
Simon Fraser (smfr)
Comment 4 2020-04-09 21:02:02 PDT
Created attachment 396042 [details] Patch
EWS
Comment 5 2020-04-10 08:27:55 PDT
Committed r259871: <https://trac.webkit.org/changeset/259871> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396042 [details].
Alexey Proskuryakov
Comment 6 2020-04-10 13:34:47 PDT
Comment on attachment 396042 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396042&action=review > Source/WebCore/platform/graphics/ca/cocoa/WebTiledBackingLayer.mm:-58 > - ASSERT_NOT_REACHED(); FWIW, the assertion was added with this comment: "Implement this and assert that it's never reached. We should never create presentation layers since we don't animate this layer."
Simon Fraser (smfr)
Comment 7 2020-04-10 20:01:09 PDT
We plainly do animate this layer.
Note You need to log in before you can comment on or make changes to this bug.