Bug 210312

Summary: Don't emit the rhs twice in `AssignResolveNode`
Product: WebKit Reporter: Devin Rousso <hi>
Component: JavaScriptCoreAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hi, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2020-04-09 16:43:03 PDT
[Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp](http://trac.webkit.org/changeset/259781/webkit/trunk/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp): ``` RefPtr<RegisterID> result = generator.emitNode(dst, m_right); if (isReadOnly) { RegisterID* result = generator.emitNode(dst, m_right); // Execute side effects first. ```
Attachments
Patch (1.65 KB, patch)
2020-04-09 16:45 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (1.80 KB, patch)
2020-04-09 17:01 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-04-09 16:45:12 PDT
Created attachment 396026 [details] Patch
Devin Rousso
Comment 2 2020-04-09 17:01:19 PDT
Created attachment 396027 [details] Patch
Yusuke Suzuki
Comment 3 2020-04-09 17:07:42 PDT
Comment on attachment 396027 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396027&action=review r=me > Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:2913 > + RefPtr<RegisterID> result = generator.emitNode(dst, m_right); // Execute side effects first. Nice.
EWS
Comment 4 2020-04-09 17:28:16 PDT
Committed r259841: <https://trac.webkit.org/changeset/259841> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396027 [details].
Radar WebKit Bug Importer
Comment 5 2020-04-09 17:29:13 PDT
<rdar://problem/61552585>
Saam Barati
Comment 6 2020-04-13 01:13:30 PDT
Comment on attachment 396027 [details] Patch No test?
Ross Kirsling
Comment 7 2020-04-13 12:41:09 PDT
(In reply to Saam Barati from comment #6) > Comment on attachment 396027 [details] > Patch > > No test? This didn't cause incorrect behavior, it was just redundant.
Note You need to log in before you can comment on or make changes to this bug.