Bug 210289

Summary: [ews] Add unit tests to ensure that step names are valid identifier
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2020-04-09 10:20:11 PDT
Add unit tests to ensure that step names used in steps.py are valid identifier (e.g.: doesn't contain space). Buildbot 0.9+ requires step names to be identifiers, and identifier can't contain spaces http://docs.buildbot.net/0.9.8/manual/installation/nine-upgrade.html#identifiers
Attachments
Patch (2.46 KB, patch)
2020-04-09 10:25 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-04-09 10:25:35 PDT
Created attachment 395973 [details] Patch
Aakash Jain
Comment 2 2020-04-09 10:28:04 PDT
This would prevent people from accidentally using spaces in step name (e.g.: https://bugs.webkit.org/show_bug.cgi?id=210202#c15)
EWS
Comment 3 2020-04-09 12:42:08 PDT
Committed r259815: <https://trac.webkit.org/changeset/259815> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395973 [details].
Radar WebKit Bug Importer
Comment 4 2020-04-09 12:43:17 PDT
<rdar://problem/61533468>
Note You need to log in before you can comment on or make changes to this bug.