Bug 210273

Summary: [GTK] Clean-up use of deprecated GtkAction
Product: WebKit Reporter: Claudio Saavedra <csaavedra>
Component: New BugsAssignee: Claudio Saavedra <csaavedra>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, ews-watchlist, gustavo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 210100    
Attachments:
Description Flags
Patch none

Claudio Saavedra
Reported 2020-04-09 06:59:13 PDT
[GTK] Clean-up use of deprecated GtkAction
Attachments
Patch (9.12 KB, patch)
2020-04-09 07:04 PDT, Claudio Saavedra 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Claudio Saavedra
Comment 1 2020-04-09 07:04:33 PDT
Created attachment 395946 [details] Patch
EWS Watchlist
Comment 2 2020-04-09 07:05:11 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Claudio Saavedra
Comment 3 2020-04-09 07:06:20 PDT
Note that MiniBrowser is still using GtkAction and other APIs that are gone in GTK4. I didn't include that in this patch as it will require more work to redo the UI and we probably want to refresh it anyway a bit.
EWS
Comment 4 2020-04-09 07:48:36 PDT
Committed r259799: <https://trac.webkit.org/changeset/259799> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395946 [details].
Radar WebKit Bug Importer
Comment 5 2020-04-09 07:49:13 PDT
<rdar://problem/61517516>
Note You need to log in before you can comment on or make changes to this bug.